Repository navigation
fix(project): show fullscreen titles placed at the end of the video - #2681
yashranaway wants to merge 3 commits into
Conversation
|
@greptileai review |
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
|
@greptileai review |
|
Thanks! The engine verify editing oracle fails on this branch: |
3f82d1b to
7660750
Compare
|
thanks, you're right, the fallback was too wide. narrowed it in 7660750 so only a hold starting at the clips' end (within float rounding) takes the last clip instant; holds outside the clips map to nothing again. also updated the editing model in crates/verify so a closing title shows the last clip frame. |
|
@greptileai review |
a fullscreen title placed right where the video ends, like a closing card, makes the timeline longer, but there was no source frame to map that extra time to. playback and export both stop as soon as a frame has no source, so the closing title never showed up.
now a hold that starts at the very end falls back to the last source instant before the end, so the title plays over the final frame. normal end of timeline behavior is unchanged. tests cover multiple clips, speed changes, transitions and an empty timeline.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issue remains.Summary
Closing fullscreen titles now hold the last source instant when their start maps to the clips’ exclusive end.
Reviews (3) · Last reviewed commit: "fix(project): only closing titles at the..." · Reviewed by Greptile