Skip to content

fix(project): show fullscreen titles placed at the end of the video - #2681

Open
yashranaway wants to merge 3 commits into
CapSoftware:mainfrom
yashranaway:fix/fullscreen-closing-title
Open

yashranaway wants to merge 3 commits into
CapSoftware:mainfrom
yashranaway:fix/fullscreen-closing-title

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

a fullscreen title placed right where the video ends, like a closing card, makes the timeline longer, but there was no source frame to map that extra time to. playback and export both stop as soon as a frame has no source, so the closing title never showed up.

now a hold that starts at the very end falls back to the last source instant before the end, so the title plays over the final frame. normal end of timeline behavior is unchanged. tests cover multiple clips, speed changes, transitions and an empty timeline.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issue remains.

Summary

Closing fullscreen titles now hold the last source instant when their start maps to the clips’ exclusive end.

  • Closing fullscreen titles show over the last clip frame.

Reviews (3) · Last reviewed commit: "fix(project): only closing titles at the..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread crates/project/src/configuration.rs Outdated
@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@richiemcilroy

Copy link
Copy Markdown
Member

Thanks! The engine verify editing oracle fails on this branch: editing/mapping/holds and editing/mapping/all report mapping mismatches in 919 random edit sequences (for example seed 1: a Hold at 0.737 s, a Split and two TrimStarts), not only the closing-title case. The new None => self.last_source()? fallback seems to map hold windows that fall outside the clips in cases where the model expects no frame. Repro: CAP_VERIFY_CASE='editing/mapping/holds' CAP_VERIFY_TIER=full cargo test -p cap-verify --test editing -- --nocapture. Could you narrow the fallback to a title that starts exactly at the clips' end, and update the editing model (crates/verify) if that case is meant to change?

@yashranaway
yashranaway force-pushed the fix/fullscreen-closing-title branch from 3f82d1b to 7660750 Compare October 18, 2026 18:37
@yashranaway

Copy link
Copy Markdown
Contributor Author

thanks, you're right, the fallback was too wide. narrowed it in 7660750 so only a hold starting at the clips' end (within float rounding) takes the last clip instant; holds outside the clips map to nothing again. also updated the editing model in crates/verify so a closing title shows the last clip frame. editing/mapping/holds and editing/mapping/all pass now.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants