Repository navigation
fix(desktop-gpui): retime mask keyframes when clip speed changes - #2677
Merged
richiemcilroy merged 3 commits intoOct 18, 2026
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing a clip's speed moved and resized mask segments but left their keyframes where they were. keyframes are timed from the mask's start, so at half speed a mask animation finished twice as early, and at 2x it ran past the end of the mask.
now each keyframe goes through the same time mapping as the mask edges, so a mask that runs across into the next clip still lines up. the test covers slowing down, speeding up, a mask spanning two clips, and undo/redo.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; the earlier mask drift issue is addressed.Summary
Preserves mask animation when clip speed changes.
The earlier drift finding is addressed: each track now gets an interpolated key at the boundary before its times change.
Reviews (2) · Last reviewed commit: "fix(desktop-gpui): split mask keyframes ..." · Reviewed by Greptile