Skip to content

fix(desktop-gpui): retime mask keyframes when clip speed changes - #2677

Merged
richiemcilroy merged 3 commits into
CapSoftware:mainfrom
yashranaway:fix/mask-keyframes-speed
Oct 18, 2026
Merged

richiemcilroy merged 3 commits into
CapSoftware:mainfrom
yashranaway:fix/mask-keyframes-speed

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

changing a clip's speed moved and resized mask segments but left their keyframes where they were. keyframes are timed from the mask's start, so at half speed a mask animation finished twice as early, and at 2x it ran past the end of the mask.

now each keyframe goes through the same time mapping as the mask edges, so a mask that runs across into the next clip still lines up. the test covers slowing down, speeding up, a mask spanning two clips, and undo/redo.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the earlier mask drift issue is addressed.

Summary

Preserves mask animation when clip speed changes.

  • Mask animations now follow clip speed changes.

The earlier drift finding is addressed: each track now gets an interpolated key at the boundary before its times change.

Reviews (2) · Last reviewed commit: "fix(desktop-gpui): split mask keyframes ..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

Comment thread apps/desktop-gpui/src/editor_edits.rs Outdated
@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@richiemcilroy
richiemcilroy merged commit 82f61b5 into CapSoftware:main Oct 18, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants