Repository navigation
fix: keep bad targets, degenerate links and cron steps from aborting the poller - #353
Conversation
…the poller An unrecognised TARGET, a zero-width or doubled-back link, the first sample of a new weathermap_data row and a */0 schedule each threw out of the poller. Cron fields now also accept lists and ranges. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
The crash fixes look good. All 712 PHP tests passed locally, and 732 passed with #352 included. Found one small issue with the new schedule handling: Sonar is also failing on duplication: 4.4% against the 3% limit. Worth clearing that before merging. Those are the two things I found to address. |
The dataset rows repeated one shape, which the new-code duplication gate counted as a copy. The same 15 cases now come from a match table and a miss table. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
|
Thanks for catching the |



An unrecognised target now counts as no data, the link geometry returns the shared vertex or a zero normal instead of dividing by zero, a new
weathermap_datarow's first sample gives a zero rate, and schedule fields accept*,N,N-M, lists and/step, with a zero step never matching. The poller hook also catches a failed map run, logs it and releases its lock, and returns instead of callingexit(1)when another run holds the lock.Tested on PHP 8.5 in Docker. The new
tests/Unit/PollerCrashGuardTest.phpreproduces each failure and fails without the fix, the full Pest suite passes apart from the twoDocumentationExampleHoverTestfailures that also fail on develop, and patch coverage is 100%. The CHANGELOG entry is in #352's branch to keep the two PRs from conflicting.Fixes #351