Skip to content

Split js/editor.js so browser tests stop slicing it by function name #346

Closed

Description

@somethingwithproof

js/editor.js is one large jQuery file of about 2,600 lines. The browser tests load pieces of it by slicing the source between function names (source.indexOf('function X(')), so reordering or renaming a function silently breaks tests. That is how EditorImagesTest broke in #331. Separate files for the picker, asset library and dialogs, each with an explicit export, would let the tests load whole files.

Activity

  1. somethingwithproof commented on Nov 11, 2026

    @somethingwithproof
    MemberAuthor

    Fixed by #347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions