Repository navigation
fix: Utilities confirmation layout, headings and port/IP partitioning names - #456
Merged
Merged
Conversation
…, port and IP partitioning names Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The renamed partition labels and new confirmation heading are missing from locales/po/cacti.pot, preventing Weblate from offering them for translation.
1 open issue
What changed in this PR
This PR improves MacTrack Utilities confirmations and clarifies that partitioning applies to both port and IP address tables.
Changes:
- Places Cancel and Continue inside one form and gives each confirmation an action-specific heading.
- Updates partitioning labels, documentation, CLI messages, and the internal action name while preserving the setting key.
- Adds confirmation regression tests and updates existing partitioning tests.
| File | Description |
|---|---|
tests/Unit/UtilitiesRequirePostTest.php |
Checks action-specific headings and updates the action name. |
tests/Unit/PartitionWebTest.php |
Tests shared-form buttons and direct actions; updates renamed calls. |
tests/Unit/PartitionRebuildTest.php |
Updates expected CLI setting labels. |
setup.php |
Renames the partition setting label and description. |
README.md |
Aligns partitioning instructions with the new labels. |
mactrack_utilities.php |
Fixes confirmation layout and headings; renames the partitioning action. |
lib/mactrack_functions.php |
Adds confirmation titles and updates the partitioning action key. |
cli/upgrade_partitioning.php |
Updates help, status messages, and comments to use the new setting name. |
CHANGELOG.md |
Records the confirmation and naming changes. |
Review effort: Balanced
xmacan
previously approved these changes
Nov 17, 2026
…oning strings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
xmacan
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
The Utilities confirmation page had three problems:
<form>(a block element) and Cancel sat outside it. Cancel now sits inside the form beside the button, so the two are side by side for every action.mactrack_utilities_convert_portstomactrack_utilities_convert_partitions.The bulk-action confirmations on the device, site, MAC and other list pages already use the action name as their heading, so they are unchanged.
Tests
The Pest suite passes (1105 passed, 12 skipped for lack of a database DSN). It adds tests that:
Translation catalogs are not touched; they are regenerated separately.