Skip to content

fix: 2182 - Heap OOB Read in switch_to_next_file() #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carbonFibreCode wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −4
Open

fix: 2182 - Heap OOB Read in switch_to_next_file() #2183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d526f
fix 2182 - Heap OOB Read in switch_to_next_file()
Mar 6, 2026
8dbca34
fix: unused variable inputfile in common.rs
Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/rust/src/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,18 @@ pub unsafe fn copy_from_rust(ccx_s_options: *mut ccx_s_options, options: Options
// Subsequent calls from ccxr_demuxer_open/close should NOT modify inputfile because
// C code holds references to those strings throughout processing.
// Freeing them would cause use-after-free and double-free errors.
if let Some(ref inputfile) = options.inputfile {
if let Some(ref _inputfile) = options.inputfile {
if (*ccx_s_options).inputfile.is_null() {
(*ccx_s_options).inputfile = string_to_c_chars(inputfile.clone());
(*ccx_s_options).num_input_files =
inputfile.iter().filter(|s| !s.is_empty()).count() as _;
let non_empty: Vec<String> = options
.inputfile
.as_ref()
.unwrap()
.iter()
.filter(|s| !s.is_empty())
.cloned()
.collect();
(*ccx_s_options).num_input_files = non_empty.len() as _;
(*ccx_s_options).inputfile = string_to_c_chars(non_empty);
}
}
(*ccx_s_options).demux_cfg = options.demux_cfg.to_ctype();
Expand Down
Loading