Repository navigation
Fix dependency naming - #718
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
- Coverage 89.89% 89.87% -0.03%
==========================================
Files 50 50
Lines 16897 16901 +4
==========================================
Hits 15189 15189
- Misses 1708 1712 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The term "indirect dependency" was used for three different things: dependencies gained through provideDeps, consumed tools/sandbox and transitively reachable packages. Define a consistent set of terms and use them throughout the documentation and code comments: * declared (direct) dependencies: named in the "depends" section * provided dependencies: listed in provideDeps (providing side) * injected dependencies: received through provideDeps (receiving side) * immediate dependencies: declared and injected dependencies * ambient dependencies: tools, sandbox and interpreters inherited from downstream recipes * transitive dependencies: recursively reachable packages Also fix the BOB_DEP_PATHS description which includes injected dependencies too. Fixes BobBuildTool#651.
Follow the unified dependency terminology in the code too. Dependencies that are received through provideDeps are called "injected" now. The public Package.getIndirectDepSteps() method is kept as deprecated alias of the new getInjectedDepSteps() to not break existing plugins.
The -p option does not recurse by itself. It only changes the output format from the tree to full package paths. Listing all transitive dependencies requires -r too.
jkloetzke
force-pushed
the
fix-dependency-naming
branch
from
October 7, 2026 20:18
ebbb44a to
e6413a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rectify the dependency terminology.
Fixes #651.