smplx-build: fix witness type conversion in single-valued either type#51
Open
smplx-build: fix witness type conversion in single-valued either type#51
Conversation
* add one more contract to ui tests
Collaborator
|
Looks good! Let's fix other incompatibility issues here as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes an error in
include_simf!macro when handling single-valuedEitherorOptiontypes in the Simplicity contract.include_simf!was incorrectly generating references for nested values in Option and Either<T, U>. After expansion, the generated code was failing because it passed&Tvalue toValue::frominstead of the ownedTtype.This PR updated the macro to generate explicit dereferences
*inner_val, correctly passing the underlying values.Why this approach?
We can solve this issue without changing the interface in different ways
caveats: double cloning
match &val {}->match val {}caveats: possible redundant object copying
By far, this is the most efficient way to fix the issue, as it avoids unnecessary copying of types.