[AutoPR azure-mgmt-monitorslis]-generated-from-SDK Generation - Python-6342622#47093
Open
azure-sdk wants to merge 11 commits into
Open
[AutoPR azure-mgmt-monitorslis]-generated-from-SDK Generation - Python-6342622#47093azure-sdk wants to merge 11 commits into
azure-sdk wants to merge 11 commits into
Conversation
…rosoft.Monitor/Slis/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '8be8c75d9bb11ea95d8a7e251db74aa78b5cd76c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6342622 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Contributor
|
Layered CRUD recording-based test scaffolding on top of the regen commit. Test file: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the azure-mgmt-monitorslis management-plane SDK generated from the TypeSpec config for 2025-03-01-preview, including version bump to 1.0.0b2, Python support metadata changes, and regenerated API surface artifacts.
Changes:
- Bumped package version to
1.0.0b2and updated spec commit metadata (tsp-location +_metadata.json). - Updated Python package metadata to require Python
>=3.10(and removed the 3.9 classifier). - Regenerated client/models/operations code and APIView properties for the new spec/emitter output.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/azure-mgmt-monitorslis/tsp-location.yaml | Updates the tracked swagger/spec commit SHA for generation provenance. |
| sdk/monitor/azure-mgmt-monitorslis/pyproject.toml | Raises minimum Python to 3.10 and updates classifiers accordingly. |
| sdk/monitor/azure-mgmt-monitorslis/generated_samples/slis_create_or_update.py | Regenerated sample content reflecting updated enum/operator strings. |
| sdk/monitor/azure-mgmt-monitorslis/CHANGELOG.md | Adds 1.0.0b2 release notes (features + breaking changes). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/_patch.py | Regenerated patch scaffold cleanup (whitespace). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/operations/_operations.py | Regenerated operations code (next-link request construction updated). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_patch.py | Regenerated patch scaffold cleanup (whitespace). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_models.py | Regenerated models and docstrings reflecting updated enums/operators. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/models/_enums.py | Regenerated enums for operator/sampling changes. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/_patch.py | Regenerated async patch scaffold cleanup (whitespace). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/operations/_operations.py | Regenerated async operations code (next-link request construction updated). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_patch.py | Regenerated async patch scaffold cleanup (whitespace). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_configuration.py | Updates async configuration docstring around api_version defaulting. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/aio/_client.py | Adjusts async client typing import strategy (Self) and api_version docs. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_version.py | Bumps version constant to 1.0.0b2. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/serialization.py | Regenerated serialization utilities (incl. header fast-path and Self import strategy). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_utils/model_base.py | Regenerated model base utilities (incl. XML deserialization fast paths and defaults behavior). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_patch.py | Regenerated patch scaffold cleanup (whitespace). |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_configuration.py | Updates sync configuration docstring around api_version defaulting. |
| sdk/monitor/azure-mgmt-monitorslis/azure/mgmt/monitorslis/_client.py | Adjusts sync client typing import strategy (Self) and api_version docs. |
| sdk/monitor/azure-mgmt-monitorslis/apiview-properties.json | Updates APIView properties and adds CrossLanguageVersion. |
| sdk/monitor/azure-mgmt-monitorslis/_metadata.json | Updates generation metadata (commit SHA and emitter version). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The test-proxy sanitizes recordings to use subscription 00000000-... and the test environment arm-sdk-tests-rg. In CI playback the env vars are not set, so the test must default to the sanitized values for the body matcher to find the recording.
Contributor
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
|
/azp run python - monitor - ci |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run python - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The test-proxy sanitizers replace the resource name in recorded responses with the literal string 'Sanitized'. Relax the equality assertion so the test passes in playback while still validating the name in live mode.
Contributor
|
/azp run python - pullrequest |
|
Commenter does not have sufficient privileges for PR 47093 in repo Azure/azure-sdk-for-python |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Regarding the typing_extensions.Self conditional import in _client.py/aio/_client.py: this is generated by the current Python TypeSpec emitter pattern and is consistent across all recently regenerated azure-mgmt-* packages. The conditional import is intentional in the emitter to use stdlib typing.Self on 3.11+ while falling back to typing_extensions on 3.10. CHANGELOG has been updated for the other two points (Python 3.10 minimum + full SamplingType wire-value changes). |
…tion Patch a strongly-typed values list[str] property and a for_list_operator(operator, values, ...) classmethod onto the generated Condition model via models/_patch.py. The property round-trips through the wire `value` string by joining/splitting on the ^^ separator used by the SLI resource provider for the in/notin operators. The factory rejects non-list operators, empty lists, and items containing the reserved separator. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace concrete subscription/resource-group/account names with <PLACEHOLDER>-style tokens so the template no longer points at a developer's personal resources. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…is Condition" This reverts commit 75a888e. The SDK-side ^^-splitting customization papers over a wire-format quirk that should be fixed in the service contract instead. Drop the customization until the service exposes a structured `values` field; once it does, the SDK will surface it naturally without us hand-rolling a parser whose round-trip / mutability semantics are non-obvious. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Address review feedback: drop the sys.version_info >= (3, 11) branch in both the sync and async generated MonitorSlisMgmtClient. Because pyproject.toml now requires Python >= 3.10, the conditional always falls through to typing_extensions (typing.Self is only available on 3.11+), so the branch is dead code. Importing Self directly matches the prevailing pattern used by the vast majority of generated mgmt clients in this repo and lets us drop the now-unused import sys and the # type: ignore comment.
Contributor
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/monitoringservice/resource-manager/Microsoft.Monitor/Slis/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '8be8c75d9bb11ea95d8a7e251db74aa78b5cd76c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6342622 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=2199 Submitted by: Saleel.Kattiyat@microsoft.com
Release Plan Details