Unify retry environment variable naming to establish canonical variab…#29683
Unify retry environment variable naming to establish canonical variab…#29683Ashid332 wants to merge 1 commit into
Conversation
…les and preserve backward compatibility with fallback aliases
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
Thank you for your contribution @Ashid332! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates retry configuration to support both canonical (AZURE_PS_HTTP_MAX_RETRIES*) and legacy (PS_HTTP_MAX_RETRIES*) environment variables, with canonical taking precedence, and adds coverage to validate precedence/fallback behavior.
Changes:
- Added legacy environment variable names and fallback logic in
ServiceClientExtension. - Added unit tests validating precedence and fallback for both general retries and 429 retries.
- Updated many generated
ISendAsync.csruntimes to read canonical env vars first, then legacy.
Reviewed changes
Copilot reviewed 2 out of 179 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Accounts/Authentication/Extensions/ServiceClientExtension.cs | Adds legacy env var fallback for retry counts while keeping canonical precedence. |
| src/Accounts/Authentication.Test/ServiceClientExtensionTests.cs | Adds tests for canonical-vs-legacy precedence and fallback scenarios. |
| generated/Workloads/SapVirtualInstance.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Workloads/Monitors.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/WindowsIotServices/WindowsIotServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/WeightsAndBiases/WeightsAndBiases.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Websites/Websites.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/VoiceServices/VoiceServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/VMware/VMware.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Terraform/Terraform.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Support/Support.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Subscription/Subscription.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StreamAnalytics/StreamAnalytics.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StorageMover/StorageMover.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StorageDiscovery/StorageDiscovery.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StorageCache/StorageCache.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StorageAction/StorageAction.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Storage/Storage.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StandbyPool/StandbyPool.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StackHCIVM/StackHCIVM.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/StackHCI/StackHCI.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/SqlVirtualMachine/SqlVirtualMachine.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/SpringCloud/SpringCloud.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Sphere/Sphere.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Site/Site.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/SignalR/SignalR.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ServiceLinker/ServiceLinker.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ServiceGroups/ServiceGroups.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ServiceBus/ServiceBus.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/SelfHelp/SelfHelp.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/SecurityInsights/SecurityInsights.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Security/Security.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Security/DefenderForStorage.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ScVmm/ScVmm.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Resources/Policy.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Resources/MSGraph.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Resources/DataBoundary.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Resources/Authorization.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ResourceMover/ResourceMover.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ResourceGraph/ResourceGraph.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Reservations/Reservations.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Relay/Relay.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Relationships/Relationships.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/RedisEnterpriseCache/RedisEnterpriseCache.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Quota/Quota.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Quantum/Quantum.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Purview/Purviewdata.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Purview/Purview.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ProviderHub/ProviderHub.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Portal/Portal.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/PolicyInsights/PolicyInsights.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/PlanetaryComputer/PlanetaryComputer.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Pinecone/Pinecone.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Peering/Peering.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/PaloAltoNetworks/PaloAltoNetworks.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Orbital/Orbital.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Oracle/Oracle.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Nginx/Nginx.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/NewRelic/NewRelic.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/NetworkFunction/NetworkFunction.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/NetworkCloud/NetworkCloud.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Network/NetworkSecurityPerimeter.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/MySql/MySql.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/MonitoringSolutions/MonitoringSolutions.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/ScheduledQueryRule.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/PipelineGroup.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/MonitorWorkspace.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/Metricdata.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/DiagnosticSetting.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/DataCollectionRule.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/Autoscale.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/ActivityLogAlert.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Monitor/ActionGroup.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/MongoDB/MongoDB.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/MixedReality/MixedReality.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Migrate/Migrate.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Mdp/Mdp.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/MarketplaceOrdering/MarketplaceOrdering.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Marketplace/Marketplace.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Maps/Maps.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ManagedServices/ManagedServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ManagedServiceIdentity/ManagedServiceIdentity.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ManagedNetworkFabric/ManagedNetworkFabric.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/MachineLearningServices/MachineLearningServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/LoadTesting/LoadTesting.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/LambdaTest/LambdaTest.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/LabServices/LabServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Kusto/Kusto.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/KubernetesRuntime/KubernetesRuntime.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/KubernetesConfiguration/KubernetesConfiguration.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/KeyVault/KeyVault.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/IoTOperationsService/IoTOperationsService.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Informatica/Informatica.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ImportExport/ImportExport.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ImageBuilder/ImageBuilder.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/HealthcareApis/HealthcareApis.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/HealthDataAIServices/HealthDataAIServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/HealthBot/HealthBot.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/HanaOnAzure/HanaOnAzure.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/GuestConfiguration/GuestConfiguration.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/GraphServices/GraphServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Functions/Functions.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/FrontDoor/FrontDoor.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/FluidRelay/FluidRelay.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Fleet/Fleet.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/FirmwareAnalysis/FirmwareAnalysis.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/FileShare/FileShare.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Fabric/Fabric.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/EventHub/EventHub.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/EventGrid/EventGrid.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ElasticSan/ElasticSan.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Elastic/Elastic.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/EdgeZones/EdgeZones.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/EdgeOrder/EdgeOrder.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/EdgeMarketplace/EdgeMarketplace.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/EdgeAction/EdgeAction.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DynatraceObservability/DynatraceObservability.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DurableTask/DurableTask.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DnsResolver/DnsResolver.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Dns/Dns.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DiskPool/DiskPool.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DisconnectedOperations/DisconnectedOperations.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DigitalTwins/DigitalTwins.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DeviceUpdate/DeviceUpdate.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DeviceRegistry/DeviceRegistry.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DesktopVirtualization/DesktopVirtualization.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DependencyMap/DependencyMap.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DedicatedHsm/DedicatedHsm.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Datadog/Datadog.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Databricks/Databricks.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DataTransfer/DataTransfer.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/DataProtection/DataProtection.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Dashboard/Dashboard.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/CustomProviders/CustomProviders.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/CustomLocation/CustomLocation.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/CostManagement/CostManagement.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ContainerRegistry/ContainerRegistry.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ContainerInstance/ContainerInstance.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ConnectedVMware/ConnectedVMware.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ConnectedNetwork/ConnectedNetwork.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ConnectedMachine/ConnectedMachine.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ConnectedKubernetes/ConnectedKubernetes.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Confluent/Confluent.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ConfidentialLedger/ConfidentialLedger.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ComputeSchedule/ComputeSchedule.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ComputeLimit/ComputeLimit.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ComputeFleet/ComputeFleet.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Compute/Compute.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Communication/EmailServicedata.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Communication/EmailService.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Communication/CommunicationServiceSmtpUsername.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Communication/Communication.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/CloudService/CloudService.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/CloudHsm/CloudHsm.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Chaos/Chaos.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ChangeAnalysis/ChangeAnalysis.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Cdn/Cdn.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Carbon/Carbon.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/BotService/BotService.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/BillingBenefits/BillingBenefits.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/BareMetal/BareMetal.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Automanage/Automanage.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Attestation/Attestation.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Astro/Astro.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ArtifactSigning/ArtifactSigning.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ArizeAI/ArizeAI.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ArcResourceBridge/ArcResourceBridge.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ArcGateway/ArcGateway.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ApplicationInsights/ApplicationInsights.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/AppConfiguration/AppConfigurationdata.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/AppConfiguration/AppConfiguration.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/AppComplianceAutomation/AppComplianceAutomation.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/App/App.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/AlertsManagement/PrometheusRuleGroups.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Alb/Alb.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/AksArc/AksArc.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Aks/Aks.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/Advisor/Advisor.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
| generated/ADDomainServices/ADDomainServices.Autorest/generated/runtime/ISendAsync.cs | Updates retry env var lookup to prefer canonical and fall back to legacy. |
Comments suppressed due to low confidence (4)
src/Accounts/Authentication/Extensions/ServiceClientExtension.cs:1
- The fallback logic prevents using the legacy variable when the canonical variable is present but invalid (e.g., non-integer). Because it checks only for presence and immediately returns
TryGetValue(canonical), an invalid canonical value yieldsnulland blocks the legacy fallback. Prefer reading/parsing canonical first and falling back only when the parsed value is null (e.g.,var v = TryGetValue(canonical); return v ?? TryGetValue(legacy);). This also avoids duplicate environment lookups.
src/Accounts/Authentication/Extensions/ServiceClientExtension.cs:1 - The fallback logic prevents using the legacy variable when the canonical variable is present but invalid (e.g., non-integer). Because it checks only for presence and immediately returns
TryGetValue(canonical), an invalid canonical value yieldsnulland blocks the legacy fallback. Prefer reading/parsing canonical first and falling back only when the parsed value is null (e.g.,var v = TryGetValue(canonical); return v ?? TryGetValue(legacy);). This also avoids duplicate environment lookups.
src/Accounts/Authentication.Test/ServiceClientExtensionTests.cs:1 - These tests mutate process-wide environment variables, which can make the suite flaky if tests run in parallel (xUnit runs tests in parallel by default). Consider isolating them by placing the class in a non-parallelized collection (or disabling parallelization for the test assembly), so concurrent tests don’t interleave environment variable changes.
src/Accounts/Authentication.Test/ServiceClientExtensionTests.cs:1 - These tests mutate process-wide environment variables, which can make the suite flaky if tests run in parallel (xUnit runs tests in parallel by default). Consider isolating them by placing the class in a non-parallelized collection (or disabling parallelization for the test assembly), so concurrent tests don’t interleave environment variable changes.
|
@microsoft-github-policy-service agree |
|
Hi @Ashid332 it looks like this pr targets files generated using AutoRest. Have you made a change to AutoRest or manually edited each file. If the change doesn't exist within AutoRest they will be overridden as soon as the AzPS is re-generated. |
…les and preserve backward compatibility with fallback aliases
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.