Open
Conversation
rlundeen2
reviewed
Mar 7, 2026
Contributor
|
We need to make sure this passes on Linux/macos as well. Are there additional steps? Assuming it fails without ffmpeg separately installed on Linux we need a test that asserts that we're providing a reasonable error message that explains what to do. |
rlundeen2
reviewed
Mar 12, 2026
| "aiofiles>=24,<25", | ||
| "appdirs>=1.4.0", | ||
| "art>=6.5.0", | ||
| "av>=14.0.0", |
Contributor
There was a problem hiding this comment.
Can you work with Hannah and Foundry to see if this should go into default or just extras?
rlundeen2
reviewed
Mar 12, 2026
| f"sample_width={audio.sample_width}, frame_rate={audio.frame_rate}" | ||
| output_path = _audio_to_wav( | ||
| video_path, | ||
| sample_rate=AudioTranscriptHelper._DEFAULT_SAMPLE_RATE, |
Contributor
There was a problem hiding this comment.
just double checking, have you re-ran this? If not, make sure you have :)
rlundeen2
reviewed
Mar 12, 2026
|
|
||
| try: | ||
| converter = AzureSpeechAudioToTextConverter() | ||
| converter = AzureSpeechAudioToTextConverter(use_entra_auth=True) |
Contributor
There was a problem hiding this comment.
Can we pass this in? We can have this as a default if it's None?
rlundeen2
approved these changes
Mar 12, 2026
Contributor
rlundeen2
left a comment
rlundeen2
left a comment
There was a problem hiding this comment.
Approved if you take and implement the comments; lmk if you have any questions
romanlutz
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing pydub as a dependency. This was only used in our audio_transcript_scorer to extract audio from a video file.
Tests and Documentation
Reran unit tests and notebooks