fix(windows): don't use version in e2e tests#8593
Open
timmy-wright wants to merge 1 commit into
Open
Conversation
timmy-wright
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd and
zachary-bailey
as code owners
timmy-wright
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the pinned WindowsProvisioningScriptsPackageURL version from the Windows e2e base template so tests no longer pin to v0.0.52, and improves cluster reuse handling for Creating/Starting provisioning states. Also adds a few generated test artifacts to .gitignore.
Changes:
- Clears
WindowsProvisioningScriptsPackageURLinbaseTemplateWindows(empty string instead of pinned v0.0.52 zip URL). - Adds explicit
CreatingandStartingcases ingetExistingCluster, and addsStartingto the in-progress states inwaitUntilClusterReady. - Ignores
test-results,coverage, andstaging/cse/windows/containerdfunc.tests.suitesbuild/test artifacts.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/node_config.go | Unpin Windows provisioning scripts URL in base NBC template. |
| e2e/cluster.go | Wait for cluster readiness when reusing clusters in Creating/Starting states. |
| .gitignore | Ignore generated test/coverage artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #