fix: cleanup nodecustomdata.yaml which are static paths on VHD#8587
Merged
Conversation
awesomenix
requested review from
Devinwong,
cameronmeissner,
lilypan26,
r2k1 and
timmy-wright
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the generated Linux cloud-init CustomData payload size by removing many write_files entries from parts/linux/cloud-init/nodecustomdata.yml, based on the assumption that these artifacts already exist at static paths on the VHD. This is intended to avoid exceeding the VMSS CustomData size limit and to support scriptless CSE rollout.
Changes:
- Removed a large set of cloud-init
write_filesentries for scripts/services/config files assumed to be pre-baked on the VHD. - Kept only the core provisioning scripts (
provision*.sh) and the init custom cloud script in the non-scriptless path.
cameronmeissner
approved these changes
May 26, 2026
Devinwong
approved these changes
May 26, 2026
awesomenix
requested review from
AbelHu,
SriHarsha001,
calvin197,
djsly,
ganeshkumarashok,
junjiezhang1997,
mxj220,
pdamianov-dev,
phealy,
sulixu,
surajssd and
zachary-bailey
as code owners
cameronmeissner
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we ran into issue where customdata has reached beyond the limit
The length of customdata 88636 for VMSS <vmss name> exceeds maximum length 87380 charactersCleanup static scripts which are part of nodecustomdata.yaml. This will allow us to rollout scriptless in that region and we wont be using the
elsecase anymore