Agentic UI: Let menus follow the theme scope they open from - #4766
Open
shaunandrews wants to merge 2 commits into
Open
Agentic UI: Let menus follow the theme scope they open from#4766shaunandrews wants to merge 2 commits into
shaunandrews wants to merge 2 commits into
Conversation
…f forcing dark Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing 6974ba3 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude traced the regression through git history and wrote the fix. Reviewed by the author.
Proposed Changes
document.body, outside theThemeProvidertheir trigger lives in. Before build(deps): bump the wordpress group with 30 updates #4320 a nestedThemeProviderinside the portal (kept for the oldcompactdensity) also re-emitted the trigger's color scope. The upgrade dropped that wrapper and compensated by hardcoding a dark surface in the menu CSS.ThemeProvider(now the public export) and removes the hardcoded colors, so a menu matches wherever it opens: dark in the sidebar, the app's light/dark scheme elsewhere. The drop shadow stays literal: theme 1.x ships no elevation tokens, and its build plugin rejects unknown--wpds-*names.Screenshots
Light color scheme,
studio uiin the browser.Composer model menu (content area) — should follow the app's light/dark scheme.
Site context menu (sidebar) — stays dark, inherited from the sidebar's fixed-dark chrome.
Testing Instructions
npm run cli:build:ui && node apps/cli/dist/cli/main.mjs ui --no-open, open http://localhost:8081.Pre-merge Checklist