Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
@claude /jetpack-review-pr 48312 quick |
|
Claude finished @mahangu's task in 54s —— View job Claude Code Review — PR #48312
Overall: Clean, well-structured approach. The design (sparse-checkout of skills from trunk, copy into caller workspace) is sound and achieves the "single source of truth" goal. A few things worth double-checking: Potential Issues1. Both checkout steps use 2. Supply-chain risk: Jetpack sparse-checkout is pinned to ref: trunkAny commit pushed to 3. The job declares Minor Notes
Verdict: Approve once the |
- Expand top-of-file comment to spell out caller responsibilities, secrets, permissions semantics, the ref:trunk supply-chain tradeoff, the wire-up overwrite contract, and the OIDC job_workflow_ref subtlety for satellites trusting cloud roles. - Append rm -rf .jetpack-shared to the wire-up step to leave a clean caller workspace. Behavior changes flagged in review (allowlist narrowing, defensive checks, contents:read default) are out of scope for this PR; deferred to follow-ups.
|
Thanks Claude. Pushed an amendment commit (e30ab62). Going through:
|
|
@claude /jetpack-review-pr 48312 quick |
|
Claude finished @mahangu's task in 58s —— View job Claude Code Review — PR #48312
All five items from the previous review have been cleanly addressed in e30ab62. The top-of-file comment block is thorough and will be genuinely useful for satellite maintainers — the OIDC One minor observation remaining:
Everything else looks correct:
Verdict: Approve. The |
Kept for parity with claude.yml line 48. If unnecessary, will clean up in a follow-up PR. |
|
I'll note that I'm a bit confused as to what this PR is trying to add. Is it for the Jetpack monorepo, or for other repos? I also would highly recommend encouraging collaboration between Happiness and the agent and such iterations to be done locally rather within a PR if we're also expecting human reviewers, as skimming through PR iterations is a high burden for humans. That said, a few notes:
More generally, what's the advantage of having this done in a GitHub Action vs. as an AI skill locally that looks at the PR? |
@kraftbj @anomiex @lezama Adding y'all bc you touched Claude workflows in this repo. 🙏🏾
Proposed changes
.github/workflows/claude-review-shared.yml— aworkflow_callreusable workflow that other Automattic repos can call to get the same AI review behavior asclaude.yml. Sparse-checks-out this monorepo's.agents/skills/jetpack-review-pr.md+.claude/commands/*.mdat runtime, then runsanthropics/claude-code-action. Single source of truth for the skill stays here.Automatticorg (mirrors the pattern inwoocommerce/.github's reusable AI-review workflow). The reusable lives in a public repo, so the guard makes the support contract explicit.claude.ymlis unchanged.Related product discussion/links
jetpack-crm,jetpack-videopress,WP-Job-Manager).Automattic/jetpack-videopressnecessary to add the first satellite caller. https://github.com/Automattic/jetpack-videopress/compare/add/ai-code-reviewDoes this pull request change what data or activity we track or use?
No. Same action, same key, same skill, same review output.
Testing instructions
The reusable workflow has no observable behavior in this repo on its own (no events trigger it directly). End-to-end test runs through the satellite caller PR: once both land, drop `@claude /jetpack-review-pr quick` on a `jetpack-videopress` PR (MEMBER/OWNER) and verify a review posts back.