Run CI on Python 3.14 as well as 3.13 - #1408
Open
yasumorishima wants to merge 3 commits into
Open
Conversation
Adds 3.14 to the matrix of the Linux, macOS and Windows workflows so the suite actually reports whether the project runs on it, rather than the question staying open.
Adds 3.14 to the matrix of the Linux, macOS and Windows workflows so the suite actually reports whether the project runs on it, rather than the question staying open.
Adds 3.14 to the matrix of the Linux, macOS and Windows workflows so the suite actually reports whether the project runs on it, rather than the question staying open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1291.
The Linux, macOS and Windows workflows all pin the matrix to
'3.13', so nothing in the repository reported whether the project runs on 3.14. This adds'3.14'alongside it in all three, and changes nothing else.Result
No dependency bump or source change is needed. With
requirements/requirements.txtuntouched — numpy 2.3.5, scipy 1.17.1, matplotlib 3.11.0, cvxpy 1.8.1, ecos 2.0.14 — the full suite passes on 3.14:Measured on a fork of this repository at this commit, running
runtests.shunchanged.I expected
ecosto be the blocker, since it is a C extension and the most likely one to lack a 3.14 wheel, which would have failed the install step rather than a test. That did not happen — it installs and the suite passes, so the answer to #1291 turns out to be simply that the matrix had not been asked the question yet.Happy to drop 3.13 instead of running both if you would rather the matrix stay at a single version.