normalize the scheme case in the Uri constructor#2239
Open
madib06ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateSupportedScheme accepts a scheme equal ignoring case to http/https/ws/wss, but the constructor derived secured with a case-sensitive compare, so a Uri built through the public constructor or withNewScheme with "HTTPS" passes validation and still reports isSecured() false, with getSchemeDefaultPort() then returning 80. That gates the TLS and credential decisions downstream: no SslHandler is installed, Proxy-Authorization goes out in the clear, Secure cookies are released, and the schemeDowngrade check on redirect never fires. UriParser already lowercases the schemes it parses, so only the direct-constructor path disagrees; normalizing in the constructor lines the two up (the adjacent webSocket line was already using equalsIgnoreCase for WSS).