Fix linkify to handle list-form markdown outputs#1602
Open
ncoop57 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the docs build (
nbdev-docs/nbdev-proc-nbs), currently broken on main:NbdevLookup.linkifyassumes markdown is a string, but notebooks store multiline mime data as lists of lines per the nbformat convention, soadd_linkscrashes withAttributeError: 'list' object has no attribute 'splitlines'on any notebook with a saved markdown output.Changes
linkify:if isinstance(md,list): md = ''.join(md)before splitting into lines. The write side re-splits on save, so round-tripping is unchanged.linkifyon a list of lines returns the joined, linkified string.Motivation
Recent fastcore releases write notebooks with nbformat-standard split lines (AnswerDotAI/fastcore#836), so cleaned notebooks now store
text/markdownoutputs as lists, whichlinkifyhad never seen before. This surfaced in PR CI (the docs build check runs on PRs, e.g. #1597) but reproduces on main directly withnbdev-proc-nbs.