Reject SPSA int params with C < 0.50 during workload validation#320
Open
yohaann196 wants to merge 6 commits intoAndyGrant:masterfrom
Open
Reject SPSA int params with C < 0.50 during workload validation#320yohaann196 wants to merge 6 commits intoAndyGrant:masterfrom
yohaann196 wants to merge 6 commits intoAndyGrant:masterfrom
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/yohaann196/OpenBench/sessions/33a68a30-9a82-4a73-8d8d-a08c562c7bc8 Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
Reject SPSA int params with C < 0.50 during workload validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
verify_spsa_inputs already rejected float params with C <= 0.00, but
had no equivalent check for int params. A C of 0 for an int param would
pass validation, get stored, and then cause a divide-by-zero in
spsa_workload_assignment_dict when computing r_values = a / c ** 2.
The minimum meaningful C for an int param is 0.50, which matches the
floor already applied in spsa_utils.py:
Also fixes a typo in the existing error message:
"Datatype must be int for float" -> "Datatype must be int or float"