Repository navigation
Conversation
zvonand
added
releasy
52 tasks done
Native `CREATE TABLE` / `DROP TABLE` for DataLakeCatalog; optionally prune on `DROP` Adaptations to antalya-26.8: - `UnityV2Catalog`, `DeltaLakeCatalogRegistration.cpp`, `test_database_unity_v2` and the Delta Kernel `createInitial` path do not exist here, so the PR's changes to them are dropped. - The "table engine without arguments" machinery (`getEngineArgsForNewTable`, `buildTableEngineArgs`, `getDefaultTableLocation`, `getDefaultTableEngineName`) is not in this branch, so `getNewTableLocation` has no namespace-location branch and the related tests in `test_database_glue` are not added. - `createNamespaceIfNotExists` keeps its two-argument form; an empty location is passed where upstream passes none. - `writesInitialMetadata` does not exist here; `isTransactional` is used in its place in `IcebergMetadata::createInitial`. - `icebergYear`/`icebergMonth`/`icebergDay`/`icebergHour` functions do not exist here, so the tests expect `toYearNumSinceEpoch` and `toRelativeDayNum`. - `SettingsChangesHistory.cpp` records the new settings `data_lake_delete_data_on_drop` and `datalake_ignore_unsupported_table_properties`.
zvonand
force-pushed
the
feature/antalya-26.8/ClickHouse-ClickHouse-pr-98670
branch
from
October 10, 2026 20:55
c971358 to
d26895d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Supports
CREATE TABLE,CREATE TABLE … AS source, andDROP TABLEforDataLakeCatalog;DROP TABLEcan request catalog-side data purge via the newdata_lake_delete_data_on_dropsetting (ClickHouse#98670 by @zvonand).Cherry-picked from ClickHouse#98670.
Documentation entry for user-facing changes
Workflow [PR]
Sync PR [sync-upstream/pr/98670]