Skip to content

Fix Client::login segfault on empty hosts_and_ports (#103603) #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BorisTyshkevich wants to merge 2 commits into
base: antalya-26.1
Choose a base branch
from
Open

Fix Client::login segfault on empty hosts_and_ports (#103603) #1696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c0b0d
Fix Client::login segfault on empty hosts_and_ports (#103603)
BorisTyshkevich Apr 27, 2026
288a897
Merge branch 'antalya-26.1' into pr1-client-login-empty-hosts
BorisTyshkevich Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion programs/client/Client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,14 @@ catch (...)
#if USE_JWT_CPP && USE_SSL
void Client::login()
{
std::string host = hosts_and_ports.front().host;
/// hosts_and_ports is populated only from explicit --host. When the host
/// came from --connection or top-level <host> in config, it stays empty,
/// and hosts_and_ports.front() dereferences a null vector slot → SIGSEGV
/// in Client::main (upstream issue #103603). Fall back to the
/// config-derived value, which always exists by this point.
std::string host = !hosts_and_ports.empty()
? hosts_and_ports.front().host
: getClientConfiguration().getString("host", "");
std::string auth_url = getClientConfiguration().getString("oauth-url", "");
std::string client_id = getClientConfiguration().getString("oauth-client-id", "");
std::string audience = getClientConfiguration().getString("oauth-audience", "");
Expand Down
Loading