Skip to content

Antalya 25.8: Remote initiator improvements 2#1638

Merged
zvonand merged 5 commits intoantalya-25.8from
feature/antalya-25.8/remote_initiator_improvements_2
May 1, 2026
Merged

Antalya 25.8: Remote initiator improvements 2#1638
zvonand merged 5 commits intoantalya-25.8from
feature/antalya-25.8/remote_initiator_improvements_2

Conversation

@ianton-ru
Copy link
Copy Markdown

@ianton-ru ianton-ru commented Apr 10, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use object_storage_remote_initiator without object_storage_cluster on initial node.

Documentation entry for user-facing changes

Solved #1607
Query with object_storage_remote_initiator and object_storage_remote_initiator_cluster can be executed, when object_storage_cluster setting is defined only on remote node.

SELECT * FROM datalake.`iceberg.table` SETTINGS object_storage_remote_initiator=1, object_storage_remote_initiator_cluster='swarm_external_name'

converted to

SELECT * FROM remote('random_node_from_swarm_external_name', iceberg(...))

Remote node random_node_from_swarm_external_name executes

SELECT* FROM iceberg(...)

as simple table function or as cluster table function depend on object_storage_cluster defined only on this node.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

Workflow [PR], commit [70d4218]

@ianton-ru
Copy link
Copy Markdown
Author

@codex review

@ianton-ru ianton-ru changed the title Feature/antalya 25.8/remote initiator improvements 2 Antalya 25.8: Remote initiator improvements 2 Apr 10, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@svb-alt svb-alt requested a review from arthurpassos April 14, 2026 14:44
arthurpassos
arthurpassos previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Collaborator

@arthurpassos arthurpassos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the limits of my knowledge, it looks ok

if (cluster_name.empty())
{
throw Exception(
ErrorCodes::LOGICAL_ERROR,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it was already here, but is LOGICAL_ERROR a good pick? Wouldn't BAD_ARGUMENTS be better? I mean, if the error / empty cluster is a code error, then ok. But if it's a missing argument from the user, then we should change

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user did not set cluster name, updateQueryForDistributedEngineIfNeeded must be called with make_cluster_function=false, this check is not executed in this case. It is a technical check to be sure I did not make mistake somewhere in code.

@alsugiliazova
Copy link
Copy Markdown
Member

Verification report: Altinity/ClickHouse PR #1638


Conclusion

PR is verified.


CI on head 70d42186 — failures

PR test workflow (3 failed jobs, 93 success, 1 still in progress)

Check Test FAIL on head Class
Integration tests (amd_asan, flaky check) test_s3_cluster::test_graceful_shutdown[3-5] Pre-existing flake — exists since 2025-11-05; test_graceful_shutdown family has 52+ FAILs / 24 PRs / 90d. Caught by the dedicated "flaky check" job, expected behavior.
Stateless tests (amd_debug, parallel) 03211_nested_json_merges Pre-existing flake — 16 FAILs / 7 PRs / 90d, unrelated to PR diff (JSON merges).
Stateless tests (amd_asan, distributed plan, parallel, 1/2) (no test FAIL recorded) Job-level error; rerun candidate.
Stateless tests (amd_asan, distributed plan, parallel, 2/2) n/a — in progress / passing per user

Regression workflow (4 failed jobs)

Check Top failure on PR-1638 builds Baseline (30d, all PRs) Class
RegressionTestsRelease / Common (settings) / settings 8 settings missing snapshots; 1 of them — object_storage_remote_initiator_cluster — is the new setting introduced by this PR object_storage_remote_initiator_cluster: 144 OK / 57 Fail across all 25.8 builds **PR-cause: need to update snapshot
RegressionTestsAarch64 / Common (settings) / settings same same same
RegressionTestsRelease / Swarms / swarms /swarms/feature/node failure/check restart swarm node, /swarms/feature/swarm joins well-known broken/flaky swarms scenarios Pre-existing
RegressionTestsAarch64 / Swarms / swarms same same same
RegressionTestsAarch64 / SSLServer (3) / ssl_server_3 /ssl server/part 3/zookeeper/fips/* (FIPS / ZK ciphers) recurrent across PRs Pre-existing infra (FIPS ZK)

@alsugiliazova alsugiliazova added the verified Approved for release label Apr 30, 2026
@zvonand zvonand merged commit 163feb9 into antalya-25.8 May 1, 2026
446 of 463 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants