Skip to content

[Tools] Fix includes - #17795

Open
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-Tools
Open

[Tools] Fix includes#17795
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-Tools

Conversation

@vkucera

@vkucera vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the tools label Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 14 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix includes [Tools] Fix includes Sep 5, 2026
@vkucera
vkucera marked this pull request as ready for review September 6, 2026 14:31
@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1b7d964 at 2026-09-06 18:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 14 warnings.'
Found 4 errors and 14 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/e3dc535117bb6c15a948a661d9ffe9300337b615/O2Physics-code-check/errors.txt
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:402:34: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:402:49: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:402:56: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Tools/PIDFeatureExtractor/pidOnnxInference.cxx:351:33: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/e3dc535117bb6c15a948a661d9ffe9300337b615/O2Physics-code-check/warnings.txt
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:283:62: warning: statement should be inside braces [readability-braces-around-statements]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:285:66: warning: statement should be inside braces [readability-braces-around-statements]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:287:50: warning: statement should be inside braces [readability-braces-around-statements]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:289:48: warning: statement should be inside braces [readability-braces-around-statements]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:291:53: warning: statement should be inside braces [readability-braces-around-statements]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:293:55: warning: statement should be inside braces [readability-braces-around-statements]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:301:50: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:301:87: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:301:103: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:399:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:400:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/PIDFeatureExtractor/pidFeatureExtractor.cxx:401:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Tools/PIDFeatureExtractor/pidOnnxInference.cxx:76:9: warning: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion]
Tools/PIDFeatureExtractor/pidOnnxInference.cxx:350:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants