Skip to content

[PWGEM] Add Event Skimmer for Dalitz taking both V0 and Elec into acc… - #17787

Open
jokonig wants to merge 1 commit into
AliceO2Group:masterfrom
jokonig:master
Open

[PWGEM] Add Event Skimmer for Dalitz taking both V0 and Elec into acc…#17787
jokonig wants to merge 1 commit into
AliceO2Group:masterfrom
jokonig:master

Conversation

@jokonig

@jokonig jokonig commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

…ount

  • New skimmer needs tables from photon-conversion-builder and dalitz-electron-skimmer. Then, based no the contents of these tables, the final tables are written into the AO2D
  • Consequently, the photon-conversion-builder and the dalitz-skimmer need to be able to write temporary tables with the same content as the original tables
  • Added these temporary tables to the datamodel
  • Templated photon-conversion-builder and Dalitz-Skimmer to be able to write both types of tables
  • Added new Dalitz skimmer that reads these tables and then writes the non-temporary ones

@github-actions github-actions Bot added pwgem datamodel photon Photon and neutral meson PAG label labels Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 231 errors, ⚠️ 145 warnings, 🔕 27 disabled

@alibuild alibuild mentioned this pull request Sep 5, 2026
Closed
jokonig
[PWGEM] Add Event Skimmer for Dalitz taking both V0 and Elec into acc…
5e14c1a 
…ount

- New skimmer needs tables from photon-conversion-builder and dalitz-electron-skimmer. Then, based no the contents of these tables, the final tables are written into the AO2D
- Consequently, the photon-conversion-builder and the dalitz-skimmer need to be able to write temporary tables with the same content as the original tables
- Added these temporary tables to the datamodel
- Templated photon-conversion-builder and Dalitz-Skimmer to be able to write both types of tables
- Added new Dalitz skimmer that reads these tables and then writes the non-temporary ones
@jokonig
jokonig marked this pull request as ready for review September 6, 2026 15:42
@jokonig
jokonig enabled auto-merge (squash) September 6, 2026 15:43
alibuild
alibuild approved these changes Sep 6, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jokonig.

@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 5e14c1a at 2026-09-06 17:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:36:3: error: 'Produces' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:37:3: error: 'Produces' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:38:3: error: 'Produces' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:39:3: error: 'Produces' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:40:3: error: 'Produces' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:42:3: error: 'Produces' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:43:3: error: 'Produces' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:138:53: error: 'TaskName' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:138:5: error: 'adaptAnalysisTask' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:138:87: error: no matching function for call to 'std::vector<o2::framework::DataProcessorSpec>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:70:27: error: 'emprimaryelectrons' was not declared in this scope; did you mean 'emPrimaryElecTmp'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:86:20: error: 'v0photonskf' was not declared in this scope; did you mean 'photonskf'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:95:25: error: 'v0photonsphivpsi' was not declared in this scope; did you mean 'o2::aod::v0photonsphivpsi'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:101:15: error: 'v0legs' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:110:18: error: 'v0legsXYZ' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:70:27: error: 'emprimaryelectrons' was not declared in this scope; did you mean 'emPrimaryElecTmp'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:80:35: error: 'emprimaryelectronsDeDxMC' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:86:20: error: 'v0photonskf' was not declared in this scope; did you mean 'photonskf'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:95:25: error: 'v0photonsphivpsi' was not declared in this scope; did you mean 'o2::aod::v0photonsphivpsi'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:101:15: error: 'v0legs' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:110:18: error: 'v0legsXYZ' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/PhotonMeson/TableProducer/skimmerDalitzEvents.cxx:114:23: error: 'v0legsDeDxMC' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@amaringarcia amaringarcia Awaiting requested review from amaringarcia amaringarcia is a code owner
@reygers reygers Awaiting requested review from reygers reygers is a code owner
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

Assignees

No one assigned

Labels

datamodel photon Photon and neutral meson PAG label pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jokonig @alibuild