Skip to content

[ALICE3] Fix includes #17784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkucera wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ALICE3] Fix includes #17784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ALICE3/TableProducer/OTF/onTheFlyTofPid.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "Common/Core/trackUtilities.h"

#include <CCDB/BasicCCDBManager.h>
#include <CommonConstants/MathConstants.h>
#include <CommonConstants/PhysicsConstants.h>
#include <DetectorsBase/Propagator.h>
#include <Framework/AnalysisDataModel.h>
Expand All @@ -56,6 +57,7 @@
#include <TRandom3.h>
#include <TString.h>

#include <algorithm>
#include <array>
#include <cmath>
#include <cstdlib>
Expand Down
2 changes: 0 additions & 2 deletions ALICE3/TableProducer/alice3Multiplicity.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
#include <Framework/OutputObjHeader.h>
#include <Framework/runDataProcessing.h>

#include <TH1.h>

#include <cmath>
#include <cstdlib>

Expand Down Expand Up @@ -109,7 +107,7 @@
++numTracksPV;
if (std::abs(track.eta()) < 1.0)
++numTracksPVeta1;
if (std::abs(track.eta()) < 0.5)

Check failure on line 110 in ALICE3/TableProducer/alice3Multiplicity.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
++numTracksPVetaHalf;
}
}
Expand Down Expand Up @@ -140,16 +138,16 @@
if (p != nullptr) {
charge = p->Charge();
}
if (std::abs(charge) < 1e-3) {

Check failure on line 141 in ALICE3/TableProducer/alice3Multiplicity.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;
}

++numMCParticles;
if (std::abs(mcParticle.eta()) < 2.5)

Check failure on line 146 in ALICE3/TableProducer/alice3Multiplicity.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
++numMCParticlesEta25;
if (std::abs(mcParticle.eta()) < 1.25)

Check failure on line 148 in ALICE3/TableProducer/alice3Multiplicity.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
++numMCParticlesEta125;
if (std::abs(mcParticle.eta()) < 0.9)

Check failure on line 150 in ALICE3/TableProducer/alice3Multiplicity.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
++numMCParticlesEta09;
}

Expand Down
2 changes: 0 additions & 2 deletions ALICE3/TableProducer/alice3TrackingTranslator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in ALICE3/TableProducer/alice3TrackingTranslator.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[o2-workflow-options] 

Do not use workflow options to customise workflow topology composition in defineDataProcessing. Use process function switches or metadata instead.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -27,7 +27,6 @@
#include <Framework/Configurable.h>
#include <Framework/DataTypes.h>
#include <Framework/HistogramRegistry.h>
#include <Framework/HistogramSpec.h>
#include <Framework/InitContext.h>
#include <Framework/OutputObjHeader.h>
#include <Framework/runDataProcessing.h>
Expand All @@ -46,12 +45,11 @@
#include <Rtypes.h>
#include <RtypesCore.h>

#include <algorithm>
#include <array>
#include <cmath>
#include <cstddef>
#include <cstdint>
#include <iostream>

Check failure on line 52 in ALICE3/TableProducer/alice3TrackingTranslator.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[include-iostream] 

Do not include iostream. Use O2 logging instead.
#include <map>
#include <string>
#include <utility>
Expand Down Expand Up @@ -541,7 +539,7 @@

// Reconstructed information
for (size_t iTrack = 0; iTrack < nTracks; ++iTrack) {
std::cout << "Processing track " << iTrack << "/" << nTracks << std::endl;

Check failure on line 542 in ALICE3/TableProducer/alice3TrackingTranslator.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).

Key key = keyOf(
fileTracksummary.m_majorityParticleId_vertex_primary->at(iTrack),
Expand Down
1 change: 1 addition & 0 deletions ALICE3/Tasks/alice3-dilepton.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
#include <TMath.h>
#include <TPDGCode.h>

#include <cstdlib>
#include <vector>

using namespace o2;
Expand Down Expand Up @@ -194,7 +195,7 @@
return HFType::kCe;
}
// pi0 not from HF
if (mother1_pdg == 111) {

Check failure on line 198 in ALICE3/Tasks/alice3-dilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
if (mother_p1.has_mothers()) {
int motherId = mother_p1.mothersIds()[0];
while (motherId > -1) {
Expand Down Expand Up @@ -687,7 +688,7 @@
&& std::abs(mother1_pdg) != o2::constants::physics::kOmega // omega
&& std::abs(mother1_pdg) != o2::constants::physics::kPhi // phi
&& std::abs(mother1_pdg) != o2::constants::physics::kJPsi // Jpsi
&& std::abs(mother1_pdg) != 100443 // psi2S

Check failure on line 691 in ALICE3/Tasks/alice3-dilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
) {
return -1;
}
Expand Down
3 changes: 0 additions & 3 deletions ALICE3/Tasks/alice3DqEfficiency.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,10 @@
#include "PWGDQ/Core/MixingHandler.h"
#include "PWGDQ/Core/MixingLibrary.h"
#include "PWGDQ/Core/VarManager.h"
#include "PWGDQ/DataModel/ReducedInfoTables.h"

#include "ALICE3/DataModel/ReducedTablesAlice3.h"
#include "Common/Core/TableHelper.h"

#include <DetectorsBase/MatLayerCylSet.h>
#include <Framework/ASoAHelpers.h>
#include <Framework/AnalysisDataModel.h>
#include <Framework/AnalysisHelpers.h>
Expand All @@ -43,7 +41,6 @@
#include <algorithm>
#include <array>
#include <cmath>
#include <cstddef>
#include <cstdint>
#include <cstdlib>
#include <cstring>
Expand Down
1 change: 0 additions & 1 deletion ALICE3/Tasks/alice3Multicharm.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
#include <cmath>
#include <cstdint>
#include <cstdlib>
#include <map>
#include <string>
#include <vector>

Expand Down
Loading