Skip to content

[Common] Improve performance of FulfillsITSHitRequirements#16397

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
ktf:pr16397
Jun 15, 2026
Merged

[Common] Improve performance of FulfillsITSHitRequirements#16397
dsekihat merged 1 commit into
AliceO2Group:masterfrom
ktf:pr16397

Conversation

@ktf

@ktf ktf commented May 26, 2026

Copy link
Copy Markdown
Member

Use a bitmask rather than an std::set.

@ktf ktf requested review from a team, alibuild, ddobrigk, dsekihat, iarsene and jgrosseo as code owners May 26, 2026 12:57
@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 44 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Improve performance of FulfillsITSHitRequirements [Common] Improve performance of FulfillsITSHitRequirements May 26, 2026
@ktf

ktf commented May 26, 2026

Copy link
Copy Markdown
Member Author

@ddobrigk can you please have a look also here? This also pops up in the profiles.

@ktf ktf changed the title [Common] Improve performance of FulfillsITSHitRequirements Improve performance of FulfillsITSHitRequirements May 26, 2026
@github-actions github-actions Bot changed the title Improve performance of FulfillsITSHitRequirements [Common] Improve performance of FulfillsITSHitRequirements May 26, 2026
Use a bitmask rather than an std::set.
@ktf ktf changed the title [Common] Improve performance of FulfillsITSHitRequirements Improve performance of FulfillsITSHitRequirements May 26, 2026
@github-actions github-actions Bot changed the title Improve performance of FulfillsITSHitRequirements [Common] Improve performance of FulfillsITSHitRequirements May 26, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 46de008 at 2026-05-30 07:08:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@ktf

ktf commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

@dsekihat any reason why this is not merged? Any reason for the TrackSelection class to have a dictionary, BTW?

@dsekihat dsekihat merged commit 879ce9a into AliceO2Group:master Jun 15, 2026
22 of 26 checks passed
@dsekihat

Copy link
Copy Markdown
Collaborator

Dear @ktf , My fault. I overlooked the automatic notification. It is merged just now.

@ktf ktf deleted the pr16397 branch June 15, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants