[PWGCF] Feature/lambdacascade correlation#14631
Closed
Oveissheibani wants to merge 4 commits into
Closed
Conversation
Oveissheibani
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 43 errors, |
github-actions
Bot
changed the title
Oveissheibani
force-pushed
the
feature/lambdacascade-correlation
branch
5 times, most recently
from
a311293 to
a90c6aa
Compare
Oveissheibani
force-pushed
the
feature/lambdacascade-correlation
branch
from
a90c6aa to
19114ff
Compare
Oveissheibani
added a commit
to Oveissheibani/O2Physics
that referenced
this pull request
Jan 29, 2026
Please consider the following formatting changes to AliceO2Group#14631
Oveissheibani
force-pushed
the
feature/lambdacascade-correlation
branch
from
26e3a67 to
65b7b3f
Compare
| #include "Common/DataModel/CollisionAssociationTables.h" | ||
| #include "Common/DataModel/EventSelection.h" | ||
| #include "Common/DataModel/Multiplicity.h" | ||
| #include "Common/DataModel/PIDResponse.h" |
Collaborator
There was a problem hiding this comment.
I think this is obsolete
It was split between TPC and TOF in a previous PR
If you were able to compile your code locally, I guess you did, that means that your code is not updated to the latest version
This is consistent with the message in the PR pointing at conflicts in the branch
Please, rebase your changes to the latest version of O2Physics
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Please, rebase your changes to the latest version of O2Physics and compile locally to fix potential needed changes
Collaborator
|
@Oveissheibani @victor-gonzalez Is this PR still supposed to be merged? |
Collaborator
Contributor
Author
|
Hello
I am sorry I did not notice the first message. It was just lost in my busy
inbox. I am plnning to merge it after some local problems is changed but
this is not coming in this week and I would finish by next week. So if one
week is okay, I am planing to merge it. Otherwise if you think this PR
should be dropped i can make another fork.
…On Thu, Mar 5, 2026 at 2:02 PM Vít Kučera ***@***.***> wrote:
*vkucera* left a comment (AliceO2Group/O2Physics#14631)
<#14631 (comment)>
@Oveissheibani <https://github.com/Oveissheibani> @victor-gonzalez
<https://github.com/victor-gonzalez> Ping
—
Reply to this email directly, view it on GitHub
<#14631 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANAHDSNINPQJCQYCSIY33ID4PHMNXAVCNFSM6AAAAACS3SDXI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMBXGQZDENZTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
Hi @Oveissheibani , thanks for the update. |
Collaborator
|
Hi @Oveissheibani , it's been three weeks. What is the status? |
Contributor
Author
|
I apologize. Sorry about that.
The code is ready.
I am just trying to rebuild my rebased O2Physics to ensure the code is
smooth.
I will send the PR by the end of today.
Best Regards
Oveis
…On Wed, Mar 25, 2026 at 6:18 PM Vít Kučera ***@***.***> wrote:
*vkucera* left a comment (AliceO2Group/O2Physics#14631)
<#14631?email_source=notifications&email_token=ANAHDSLNX46JNH2CAZAFVXT4SRSLVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGA2DINRQHEZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4130446093>
Hi @Oveissheibani <https://github.com/Oveissheibani> , it's been three
weeks. What is the status?
—
Reply to this email directly, view it on GitHub
<#14631?email_source=notifications&email_token=ANAHDSLNX46JNH2CAZAFVXT4SRSLVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGA2DINRQHEZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4130446093>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANAHDSI5ZQ3HM2OHIJI7SB34SRSLVAVCNFSM6AAAAACS3SDXI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMZQGQ2DMMBZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple correlation task for Lambda(anti-Lambda) – Cascade pairs.
Includes:
Added to PWGCF/TwoParticleCorrelations/Tasks.
Updated CMakeLists.txt.