Skip to content

o2dpg_sim_workflow.py: only add reco tasks of smaller detectors if they are active - #2445

Open
ehellbar wants to merge 3 commits into
AliceO2Group:masterfrom
ehellbar:pr2445
Open

o2dpg_sim_workflow.py: only add reco tasks of smaller detectors if they are active#2445
ehellbar wants to merge 3 commits into
AliceO2Group:masterfrom
ehellbar:pr2445

Conversation

@ehellbar

@ehellbar ehellbar commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ehellbar

ehellbar commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

this fixes the second issue in https://its.cern.ch/jira/browse/O2-7142?focusedId=7427580&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-7427580

@ehellbar

ehellbar commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

for some of the matching tasks, the new logic might not be correct, still checking

ehellbar
ehellbar commented Aug 31, 2026
View reviewed changes
Comment thread MC/bin/o2dpg_sim_workflow.py
#<--------- MFT-MCH forward matching
forwardmatchneeds = [MCHRECOtask['name'],
MFTRECOtask['name'] if isActive("MFT") else None,
MFTRECOtask['name'],

@ehellbar ehellbar Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the MFT reco task to an unconditional requirement for the forward matching task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawenzel sawenzel sawenzel approved these changes
@jackal1-66 jackal1-66 Awaiting requested review from jackal1-66 jackal1-66 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ehellbar @sawenzel