fix(ParallelMuse): repair stale call sites that crash compressed_reasoning_aggregation#262
Open
Osamaali313 wants to merge 1 commit into
Open
Conversation
…gregation Three leftovers from a refactor that removed data_path threading break the only entry point of compressed_reasoning_aggregation.py: - main() calls call_converge(sem, filtered_cluster, data_path) but call_converge takes 2 params -> TypeError at coroutine creation, aborting the run on the first cluster. - call_state_report calls get_llm_response(messages, max_tokens, data_path); get_llm_response takes 2 params and data_path is not in scope here -> Name Error / TypeError. The sibling call at line 215 already uses the correct 2-arg form. - call_info_integrate returns a bare string on the response-is-None path, while its other returns are 2-tuples and the caller unpacks two values (merge_num, prediction) -> ValueError on any integrate failure. Drop the stray data_path arguments and return a 2-tuple on the error path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WebAgent/ParallelMuse/compressed_reasoning_aggregation.pyhas three stale call sites left over from a refactor that removeddata_paththreading. They break the script's only entry point (main()→asyncio.run(main())), and each is provably wrong against the function's own definition (and, forget_llm_response, against the correct sibling call in the same file).1.
call_converge— wrong argument count (crashesmain()on launch)call_convergeisasync, so the extra argument raises immediately when the coroutine object is created — the loop aborts on the first cluster.2.
get_llm_response— wrong argument count + undefined namedata_pathisn't a parameter ofcall_state_reportand isn't a module global, so line 175 hitsNameError(and a 3-arg/2-paramTypeError). Line 215 shows the intended 2-arg form.3.
call_info_integrate— inconsistent return typeThe caller unpacks two values —
merge_num, prediction = await call_info_integrate(...)— so the bare-string error path raisesValueError: too many values to unpack (expected 2)whenever the integrate LLM call fails.Fix
Verification
call_converge/get_llm_responsecall now matches its 2-parameter definition, and all threecall_info_integratereturns are 2-tuples.python -m py_compilepasses.TypeError/NameError/ValueError) and confirms the corrected calls succeed.The full pipeline needs an LLM server (
REPORT_CONVERGE_BASE_URL_POOL) and a rollout file, so I couldn't run it end-to-end — but these three defects are argument-count / return-type errors that are unambiguous against the file's own definitions and its own correct sibling call, and they sit on the script's only code path.