"MaxPayloadLength" -> "maxPayloadLength" in AppendFragmentedMessage#132
Open
strangelydim wants to merge 1 commit intomasterfrom
Open
"MaxPayloadLength" -> "maxPayloadLength" in AppendFragmentedMessage#132strangelydim wants to merge 1 commit intomasterfrom
strangelydim wants to merge 1 commit intomasterfrom
Conversation
…a "maxPayloadLength" parameter accidentally used the "MaxPayloadLength" (note the capital "M") _property_ in one place instead. Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Awfully subtle difference... and currently does not really matter or cause a bug, since everywhere that calls the version of
AppendFragmentedMessagewith amaxPayloadLengthparam just happens to pass in theMaxPayloadLengthproperty value anyway. But probably should be fixed nonetheless.