Adding Image.RawPoll & fixing a couple polling bugs#129
Open
strangelydim wants to merge 1 commit intomasterfrom
Open
Adding Image.RawPoll & fixing a couple polling bugs#129strangelydim wants to merge 1 commit intomasterfrom
strangelydim wants to merge 1 commit intomasterfrom
Conversation
strangelydim
commented
May 1, 2026
strangelydim
commented
- Added Image.RawPoll; same semantics as Java.
- Added a public FileStream accessor for LogBuffers, enabling use of zero-copy Socket.SendFile (via SafeFileHandle) if desired.
- Image.BlockPoll was missing a "!" in "if (_isClosed)", so it previously would only advance the subscriber position if the image was closed (and then maybe crash). Fixed.
- Image.BlockPoll was missing 32-bit int overflow handling for the case of (offset + blockLengthLimit) being > int.MaxValue. Fixed.
New: Added a public FileStream accessor for LogBuffers, enabling use of zero-copy Socket.SendFile (via SafeFileHandle) if desired. Bug: Image.BlockPoll was missing a "!" in "if (_isClosed)", so it previously would only advance the subscriber position if the image _was_ closed (and then maybe crash). Fixed. Bug: Image.BlockPoll was missing 32-bit int overflow handling for the case of (offset + blockLengthLimit) being > int.MaxValue. Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.