Skip to content

Comments

Improved Splash Screen#1888

Merged
RohitKushvaha01 merged 6 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:main
Feb 20, 2026
Merged

Improved Splash Screen#1888
RohitKushvaha01 merged 6 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:main

Conversation

@RohitKushvaha01
Copy link
Member

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 20, 2026

Greptile Summary

Refactored the splash screen implementation to display richer debug information (app version, Android version, WebView version, and language) in a cleaner, more maintainable way. The changes include:

  • Replaced CSS pseudo-elements (::before and ::after) with proper HTML elements for better structure
  • Added setDebugInfo() function that extracts system information from user agent and displays it in the splash screen
  • Moved inline polyfills to the existing polyfill.js module (already loaded in src/main.js)
  • Removed obsolete touch event listener override code that was never used
  • Updated Babel dependencies to latest versions
  • Implemented MutationObserver to reactively update splash screen content when attributes change

Confidence Score: 5/5

  • Safe to merge - clean refactoring with improved functionality
  • The changes are well-structured improvements to the splash screen. The removed code (polyfills and touch event listeners) is either redundant or unused. The new implementation provides better debug information and uses modern patterns (MutationObserver) for reactivity. Previous review comments about console.err and the 5-second delay have been addressed.
  • No files require special attention

Important Files Changed

Filename Overview
.vscode/settings.json Added trailing newline - formatting change only
package-lock.json Updated Babel dependencies to latest versions
src/main.js Added setDebugInfo() function to display enhanced version info (app version, Android version, WebView version, language) in splash screen
www/index.html Refactored splash screen to use proper HTML elements with MutationObserver; removed obsolete polyfills (now in polyfill.js); removed unused touch event listener code

Sequence Diagram

sequenceDiagram
    participant HTML as index.html
    participant Cordova
    participant Main as main.js
    participant Splash as Splash Screen
    participant Body as document.body

    HTML->>HTML: Load page with class="loading"
    HTML->>Splash: Display splash screen
    HTML->>HTML: DOMContentLoaded
    HTML->>Splash: Setup MutationObserver
    
    Cordova->>Main: deviceready event
    Main->>Main: onDeviceReady()
    Main->>Main: setDebugInfo()
    Main->>Main: Extract Android & WebView versions
    Main->>Body: setAttribute("data-version", info)
    Body->>Splash: MutationObserver detects change
    Splash->>Splash: Update version display
    
    Main->>Body: setLoadingMessage("Loading settings...")
    Body->>Splash: MutationObserver detects change
    Splash->>Splash: Update message display
    
    Main->>Main: App initialization complete
    Main->>Body: Remove "loading" class
    Splash->>Splash: Hide splash screen
Loading

Last reviewed commit: 69a38e8

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

RohitKushvaha01 and others added 3 commits February 20, 2026 16:26
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@RohitKushvaha01
Copy link
Member Author

@greptileai

@UnschooledGamer UnschooledGamer added the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Feb 20, 2026
@github-actions github-actions bot removed the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Feb 20, 2026
@github-actions

This comment has been minimized.

@github-actions
Copy link

Preview Release for this, has been built.

Click here to view that github actions build

@bajrangCoder

This comment has been minimized.

@RohitKushvaha01 RohitKushvaha01 merged commit 3ef0246 into Acode-Foundation:main Feb 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants