Improved Splash Screen#1887
Closed
RohitKushvaha01 wants to merge 0 commit intoAcode-Foundation:mainfrom
Closed
Conversation
Contributor
Greptile SummaryAttempted to improve the splash screen by replacing CSS pseudo-elements ( Critical Issues Found
The Confidence Score: 0/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Page Load] --> B[DOMContentLoaded Event]
B --> C[updateSplash function]
C --> D{getElementById splash}
D -->|Element exists| E[Update splash-version text]
D -->|Element missing| F[Return early - CURRENT BUG]
E --> G[Update splash-message text]
G --> H[MutationObserver watches body attributes]
H --> I[Listen for data-version & data-small-msg changes]
style F fill:#ff6b6b
style D fill:#ffd93d
Last reviewed commit: 6ee26a0 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
www/index.html
Outdated
Comment on lines
180
to
181
| const splash = document.getElementById("splash"); | ||
| if (!splash) return; |
Contributor
There was a problem hiding this comment.
getElementById("splash") will always return null - there's no element with id="splash" in the HTML body
Suggested change
| const splash = document.getElementById("splash"); | |
| if (!splash) return; | |
| const splash = document.getElementById("splash"); | |
| if (!splash) { | |
| // Create splash element if it doesn't exist | |
| const splashDiv = document.createElement("div"); | |
| splashDiv.id = "splash"; | |
| splashDiv.innerHTML = '<div class="splash-version"></div><div class="splash-message"></div>'; | |
| document.body.appendChild(splashDiv); | |
| } |
www/index.html
Outdated
Comment on lines
262
to
263
| <wc-page id="root" class="primary"></wc-page> | ||
| </body> |
Contributor
There was a problem hiding this comment.
duplicate <wc-page> element and closing </body> tag
Suggested change
| <wc-page id="root" class="primary"></wc-page> | |
| </body> | |
| </html> |
Contributor
Additional Comments (3)
|
RohitKushvaha01
force-pushed
the
main
branch
from
6ee26a0 to
4a72e5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.