Small updates to standard library#565
Open
Tjalle-S wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
The change making |
Member
|
9.4.1 is still pretty recent, so yes, a conditional would be appropriate I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes some small additions to the standard library, bringing it more in line with
base:id(occasionally useful) and(~)(previously built-in syntax) fromData.Array.Accelerate.jointoData.Array.Accelerate.Control.Monad.Monoidinstance forMaybeto require only aSemigroupinstance for the element, instead ofMonoid.Eqinstance for(sh :. i)to support non-integer shapes. May be useful in combination with slices.Add
Eqinstances forAllandAny shto support this.How has this been tested?
No additional tests are required. Most of these changes don't change or introduce implementations. The new
joinfunctions is a common utility function, with the same implementation as inbase.Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist