Repository navigation
Verify real TypeScript timers and published coverage on all platforms - #69
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript consumer CI previously covered synchronous utilities. Add peek-readable 5.4.2 at
9cef754de7baad45e43195bbb35bd9bbf30abbc9to the existing Linux, Windows, and macOS published-coverage matrix. All 29 unchanged upstream tests run with real clocks and timers, including delayed Node stream delivery and cancellation of pending reads. An observing Mocha hook verifies native timer activity; three isolated negative controls reject replaced clocks, missing timers, and unawaited callbacks.Require native c8 and DotCov counts to match per file, and require totals to match the same commit's published Coveralls report: 205/209 lines and 54/57 branches. Exercise the actual badge action against a local bare origin for a green baseline badge and independent red 100% line/branch failures, checking exit codes, action outcomes, exact files, and commits. README documentation distinguishes Coveralls' combined 97.37% from DotCov's separate 98.1% line / 94.7% branch display. DotCov's own 100% line and branch gate is unchanged.
Local validation: all 29 upstream tests and three guard controls passed; published and per-file counts matched; the badge script published and verified all three expected outcomes; actionlint, shellcheck, and git diff --check passed. The PR CI run passed on its first attempt, including every new Linux/Windows/macOS job and DotCov's 100% gate. Downloaded artifacts confirm 29/29 tests, native timer callback evidence, and exact 205/209 line and 54/57 branch counts on each platform.