Repository navigation
Verify pydash with real timer threads on Linux, Windows, and macOS - #68
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deterministic README coverage run stabilizes pydash's debounce assertions but cannot validate real timer-thread races. Add a separate, mandatory suite using the pinned pydash implementation with real clocks, locks, and
threading.Timeron Linux, Windows, and macOS.Five scenarios run three times each: background delivery/last-result reuse, cancellation after a timer fires, callers blocked behind a callback, eight concurrent callers, and maximum-wait delivery during a burst. Events, barriers, and method-entry profiling coordinate the interleavings without short-sleep timing assertions. Four negative controls reject removed stale-generation protection, missing callback locking, disabled maximum wait, and uncaught background exceptions; another verifies a deadlocked subprocess is killed and reaped. All 20 checks must pass, and their JUnit report is retained.
The real-thread suite contributes no data to the independent 2,274-test coverage measurement. That measurement must still match the published 2,607/2,607 per-file counts, and DotCov's own 100% line/branch gate remains enforced. No retries, relaxed thresholds, or additional exclusions.
Validation: all 28 local clock/thread checks and the full 2,274-test measurement passed on macOS; actionlint, shellcheck, and diff checks passed. CI run 38138101892 passed on attempt 1, including all 20 real-thread checks on each platform, exact coverage comparisons, actual badge publication, both full DotCov test jobs, and its 100% line/branch gate.