Repository navigation
Make pydash coverage checks independent of timer scheduling - #67
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pydash's README coverage job failed on hosted macOS when its 10 ms sleeps raced a 15 ms debounce timer. A scoped pytest fixture now advances time and dispatches timers deterministically for the two debounce tests. The pinned upstream implementation, locks, test assertions, and coverage configuration remain unchanged; the fixture restores real time after each test.
Every Python matrix job tests deadline ordering, cancellation, fixture isolation, and failure detection, including repeated upstream assertions with 30 ms scheduler stalls and deliberately early/late timers. The full measurement requires JUnit evidence that exactly the two intended tests used the fixture and checks that tracked upstream source, tests, and configuration remain unchanged.
All 2,274 tests, zero skips/errors, the exact 2,607/2,607 per-file coverage comparison, DotCov's 100% gate, and badge publication checks remain mandatory. No test retries, extra exclusions, or threshold changes.
Validation on macOS: 8 clock regression tests passed; the full upstream measurement passed all 2,274 tests and matched the published coverage exactly; the actual badge script published and verified a 100.0% badge against a local bare origin.
actionlint,shellcheck, andgit diff --checkpassed. CI runs the fixture checks and full coverage/badge comparison on Linux, Windows, and macOS.CI run 38136600863 passed on attempt 1: all Linux/Windows/macOS timing, coverage, and badge jobs, both full DotCov test jobs, and the unchanged 100% coverage gate. No manual rerun was used.