Repository navigation
Verify README coverage badges at the same upstream commits - #66
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI comparisons against the published coverage behind actual upstream README badges. The new Linux/Windows/macOS matrix checks out the SHA recorded by Coveralls, verifies the README embeds the badge, runs the full upstream test suite, and compares fresh native coverage and DotCov results with the saved historical evidence. This prevents a moving badge or a different source revision from becoming the baseline.
98e81116ef4197b42dca8c3fde8d1e8166e2a81f, Coveralls build 68651498. All 339 tests pass; c8/Mocha and DotCov match the published 100%, 245/245 lines and 88/88 branches.f46de3669742c075e5379c1e193c86c1c2c70dc2, Coveralls build 81442862. All 2,274 tests and doctests pass. DotCov matches the published 100% and the Python 3.12 job's 2,607/2,607 lines, including every file. The overall Coveralls build aggregates five installed Python environments; the saved job metadata, commit statuses, and log table establish the per-environment comparison.The actual composite action publishes a matching green badge to a local bare origin in each job. Assertions check its percentage, verdict, exit code, exact JSON/SVG bytes, and history. These jobs gate releases and retain comparison artifacts. README and test notes explain the reference sources, toolchain pins, aggregation, and line-only Python baseline; the existing Python branch/failure tests and DotCov's 100% gate remain in place.
Local validation passed: actionlint, shellcheck, both complete upstream suites, historical/native/DotCov comparisons, real badge script publication, and rejection of an incorrect upstream commit before executing tests. Hosted CI run 38135376663 passed all six new combinations, all existing consumer/badge jobs, and the full Linux/Windows tests with DotCov at 100% line/branch coverage. The new report and reference artifacts are retained. Pydash's macOS job required one unchanged rerun after its upstream debounce test overshot a 15 ms deadline; all 2,274 tests and exact count comparisons passed on that rerun.