arm64:dts: Add SP8 PRB VR FS1606#268
Open
modolaty wants to merge 1 commit into
Open
Conversation
Add new System VR FS1606 for SP8 PRBs Falcon and Seagull Tested: - verified in Falcon and Seagull Signed-off-by: modolaty <mohsen.dolaty@amd.com>
anshaw9
approved these changes
May 27, 2026
anshaw9
left a comment
There was a problem hiding this comment.
Looks good overall.
Just one small suggestion:
-
We can combine the compatible entries into a single line:
compatible = "tdk,fs1606a", "pmbus"; -
Also, for consistency, we may prefer lowercase hex formatting for addresses:
reg = <0x09>;
reg = <0x0a>;
Suggested format:
p1v8aux@09 {
// P1V8_AUX VRM
// TDK: FS1606
compatible = "tdk,fs1606a", "pmbus";
reg = <0x09>;
};
p0v85aux@0a {
// P0V85_AUX VRM
// TDK: FS1606
compatible = "tdk,fs1606a", "pmbus";
reg = <0x0a>;
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new System VR FS1606 for SP8 PRBs Falcon and Seagull
Tested: