fix: update role none to match role presentation, update role doc-pullquote to match specification#551
fix: update role none to match role presentation, update role doc-pullquote to match specification#551huynhducduy wants to merge 3 commits intoA11yance:mainfrom
none to match role presentation, update role doc-pullquote to match specification#551Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
cmorten
left a comment
There was a problem hiding this comment.
Not that my approval is worth much, but LGTM
I wonder with future synonyms dropping such as image for img whether synonyms should be described as part of the interface (perhaps as part of related concepts, or a new field), but maybe one for a separate change
|
tests appear to be failing |
|
Worth noting the "update role doc-pullquote to match specification" aspect of this change is as a result of differences between versions 1.0 and 1.1 of the DPUB-ARIA specification, see:
In addition to the superclass role, there are also differences in the listed "inherited states and properties". Assuming aria-query was based off of the 1.0 spec (a reasonable assumption given it's reflection), this should be considered a breaking change. |
Description
noneintroduced as a synonym topresentationrole, thus must have the same configuration aspresentationrole.doc-pullquoteincorrectedly havesuperClassofnone, which should besectionSumary of changes
noneto match rolepresentationnoneto be the same as rolepresentation's testssuperClassofdoc-pullquotetosectioninstead ofnone