Skip to content

feat: support multi-node batch installation in Skills Hub#12921

Merged
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@feat_skills_hub
Jun 2, 2026
Merged

feat: support multi-node batch installation in Skills Hub#12921
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@feat_skills_hub

Conversation

@ssongliu
Copy link
Copy Markdown
Member

@ssongliu ssongliu commented Jun 2, 2026

No description provided.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 085d20cf17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread core/i18n/lang/zh.yaml
AppInstallTask: "应用安装任务"
PushAppFailed: "推送应用安装任务失败"
SkillHubInstallTask: "安装技能 [{{ .name }}]"
SkillHubInstallToTarget: "安装技能 {{ .name }} 到目标 {{ .target }}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the same placeholder for target installs

This locale is the only new SkillHubInstallToTarget message that requires both .name and .target; the other locales only require .name, and the i18n helpers commonly localize messages with a single {name: ...} value. In the Chinese locale, that same target-install task title would render the missing target as <no value> instead of showing the target name, so keep the placeholder contract consistent with the other translations or update the caller to always provide target.

Useful? React with 👍 / 👎.

@wanghe-fit2cloud wanghe-fit2cloud merged commit 6546915 into dev-v2 Jun 2, 2026
4 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the pr@dev-v2@feat_skills_hub branch June 2, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants