Skip to content

fix: adjust permission dropdown behavior#12774

Merged
ssongliu merged 1 commit into
dev-duofrom
fix/permission-dropdown-20260519
May 19, 2026
Merged

fix: adjust permission dropdown behavior#12774
ssongliu merged 1 commit into
dev-duofrom
fix/permission-dropdown-20260519

Conversation

@ssongliu
Copy link
Copy Markdown
Member

No description provided.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented May 19, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ac0643888

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +152 to 154
<el-dropdown-item
:disabled="checkStatus('start', row)"
@click="onOperate('start', row)"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep permission guard on status actions

When a user only has view permission, v-permission disables the Status button but the dropdown trigger is still attached to the wrapping component/root, so the hover dropdown can still open. These replacement el-dropdown-items no longer have v-permission/FuDropdownItem, so any action allowed by checkStatus remains clickable and calls onOperate, allowing read-only users to start/stop/restart containers from this menu. Keep the permission directive on the action items or disable the dropdown itself for non-manage users.

Useful? React with 👍 / 👎.

@ssongliu ssongliu merged commit aff5a4e into dev-duo May 19, 2026
2 of 3 checks passed
@ssongliu ssongliu deleted the fix/permission-dropdown-20260519 branch May 19, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants