Skip to content

Add tests for deprecated tool parameter shims #221

@Kamilbenkirane

Description

@Kamilbenkirane

Priority: Critical
Related: #199

The web_search=True → tools=[WebSearch()] migration shim (text/client.py:54-64) has zero tests. No verification that:

  • The deprecation warning fires
  • The shim produces the same behavior as tools=[WebSearch()]
  • stacklevel=4 points to the correct caller frame
  • Combining old + new params works or errors appropriately

What to fix:

  • Add test asserting DeprecationWarning is emitted for web_search=True
  • Add test asserting x_search=True and code_execution=True shims work
  • Add test for combining web_search=True with tools=[...]
  • Verify stacklevel points correctly

Files:

  • src/celeste/modalities/text/client.py:43-67

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions