From 4793af526ecf0d721b832ef52d254c7f8a120608 Mon Sep 17 00:00:00 2001 From: Takuma Kajikawa Date: Tue, 7 Jul 2026 13:03:22 +0900 Subject: [PATCH] fix: stop composer test from masking failures and skipping tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test script appended '|| exit 0', so 'composer test' (and the 'check' aggregate) reported success even when tests failed. Worse, the report block in phpunit.xml made PHPUnit 12 abort without running any tests when no coverage driver (pcov/xdebug) is loaded — locally that meant 'No tests executed!' while the script still exited 0. CI is unaffected: it loads pcov and passes coverage options on the command line, so the XML report block was unused. Remove both. 'composer test' now runs the suite everywhere and propagates failures; coverage reports remain available via the CLI flags CI already uses. Claude-Session: https://claude.ai/code/session_017XTM7pxbWPVNLV639i5WgK --- composer.json | 2 +- phpunit.xml | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/composer.json b/composer.json index e07f270..ece4fa4 100644 --- a/composer.json +++ b/composer.json @@ -30,7 +30,7 @@ } }, "scripts": { - "test": "phpunit --do-not-fail-on-warning || exit 0", + "test": "phpunit", "phpstan": "phpstan analyse", "cs-fix": "php-cs-fixer fix --verbose", "cs-check": "php-cs-fixer fix --verbose --dry-run", diff --git a/phpunit.xml b/phpunit.xml index a696c19..7a68337 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -33,10 +33,4 @@ src - - - - - - \ No newline at end of file