fix(supervisor): remove legacy deployment dequeue endpoint

Mono-RevId: 631b87fb233a09594079bbe4e1ad5f26b3502b4b

Author: carderne

apps/supervisor/src/workloadServer/index.ts

@@ -9,7 +9,6 @@ import {
   type WorkloadClientToServerEvents,
   type WorkloadContinueRunExecutionResponseBody,
   WorkloadDebugLogRequestBody,
-  type WorkloadDequeueFromVersionResponseBody,
   WorkloadHeartbeatRequestBody,
   type WorkloadHeartbeatResponseBody,
   WorkloadRunAttemptCompleteRequestBody,
@@ -721,43 +720,7 @@ export class WorkloadServer extends EventEmitter<WorkloadServerEvents> {
               { highFrequency: true }
             ),
         }
-      )
-      .route("/api/v1/workload-actions/deployments/:deploymentId/dequeue", "GET", {
-        paramsSchema: z.object({
-          deploymentId: z.string(),
-        }),
-
-        handler: async (ctx) =>
-          this.wideRoute(
-            ctx,
-            "deployment.dequeue",
-            "/api/v1/workload-actions/deployments/:deploymentId/dequeue",
-            "GET",
-            async () => {
-              const { req, reply, params } = ctx;
-              const dequeueResponse = await this.workerClient.dequeueFromVersion(
-                params.deploymentId,
-                1,
-                this.runnerIdFromRequest(req)
-              );
-
-              if (!dequeueResponse.success) {
-                this.logger.error("Failed to get latest snapshot", {
-                  deploymentId: params.deploymentId,
-                  error: dequeueResponse.error,
-                });
-                reply.empty(500);
-                return;
-              }
-
-              reply.json(
-                dequeueResponse.data.map(
-                  legacifyCheckpointType
-                ) satisfies WorkloadDequeueFromVersionResponseBody
-              );
-            }
-          ),
-      });
+      );
 
     if (env.SEND_RUN_DEBUG_LOGS) {
       httpServer.route("/api/v1/workload-actions/runs/:runFriendlyId/logs/debug", "POST", {

apps/webapp/app/routes/engine.v1.worker-actions.deployments.$deploymentFriendlyId.dequeue.ts

@@ -139,21 +139,6 @@ export class SupervisorHttpClient {
     );
   }
 
-  /** @deprecated Not currently used */
-  async dequeueFromVersion(deploymentId: string, maxRunCount = 1, runnerId?: string) {
-    return this.request(
-      "dequeue_from_version",
-      WorkerApiDequeueResponseBody,
-      `${this.apiUrl}/engine/v1/worker-actions/deployments/${deploymentId}/dequeue?maxRunCount=${maxRunCount}`,
-      {
-        headers: {
-          ...this.defaultHeaders,
-          ...this.runnerIdHeader(runnerId),
-        },
-      }
-    );
-  }
-
   async heartbeatWorker(body: WorkerApiHeartbeatRequestBody) {
     return this.request(
       "heartbeat_worker",

packages/core/src/v3/runEngineWorker/supervisor/http.ts

@@ -132,11 +132,6 @@ export type WorkerApiRunLatestSnapshotResponseBody = z.infer<
   typeof WorkerApiRunLatestSnapshotResponseBody
 >;
 
-export const WorkerApiDequeueFromVersionResponseBody = DequeuedMessage.array();
-export type WorkerApiDequeueFromVersionResponseBody = z.infer<
-  typeof WorkerApiDequeueFromVersionResponseBody
->;
-
 export const DebugLogPropertiesValue = z.union([
   z.string(),
   z.number(),

packages/core/src/v3/runEngineWorker/supervisor/schemas.ts

@@ -9,7 +9,6 @@ import {
   WorkloadHeartbeatResponseBody,
   WorkloadRunAttemptCompleteResponseBody,
   WorkloadRunAttemptStartResponseBody,
-  WorkloadDequeueFromVersionResponseBody,
   WorkloadSuspendRunResponseBody,
   WorkloadContinueRunExecutionResponseBody,
   WorkloadRunSnapshotsSinceResponseBody,
@@ -23,18 +22,16 @@ type WorkloadHttpClientOptions = WorkloadClientCommonOptions;
 export class WorkloadHttpClient {
   private apiUrl: string;
   private runnerId: string;
-  private readonly deploymentId: string;
 
   constructor(private opts: WorkloadHttpClientOptions) {
     this.apiUrl = opts.workerApiUrl.replace(/\/$/, "");
-    this.deploymentId = opts.deploymentId;
     this.runnerId = opts.runnerId;
 
     if (!this.apiUrl) {
       throw new Error("apiURL is required and needs to be a non-empty string");
     }
 
-    if (!this.deploymentId) {
+    if (!opts.deploymentId) {
       throw new Error("deploymentId is required and needs to be a non-empty string");
     }
   }
@@ -234,18 +231,4 @@ export class WorkloadHttpClient {
       console.error("Failed to send debug log", { error });
     }
   }
-
-  /** @deprecated Not currently used */
-  async dequeue() {
-    return wrapZodFetch(
-      WorkloadDequeueFromVersionResponseBody,
-      `${this.apiUrl}/api/v1/workload-actions/deployments/${this.deploymentId}/dequeue`,
-      {
-        method: "GET",
-        headers: {
-          ...this.defaultHeaders(),
-        },
-      }
-    );
-  }
 }

packages/core/src/v3/runEngineWorker/workload/http.ts

@@ -7,7 +7,6 @@ import {
   WorkerApiRunAttemptStartRequestBody,
   WorkerApiRunAttemptStartResponseBody,
   WorkerApiRunLatestSnapshotResponseBody,
-  WorkerApiDequeueFromVersionResponseBody,
   WorkerApiContinueRunExecutionRequestBody,
   WorkerApiDebugLogBody,
   WorkerApiRunSnapshotsSinceResponseBody,
@@ -61,11 +60,6 @@ export type WorkloadRunLatestSnapshotResponseBody = z.infer<
 export const WorkloadDebugLogRequestBody = WorkerApiDebugLogBody;
 export type WorkloadDebugLogRequestBody = z.infer<typeof WorkloadDebugLogRequestBody>;
 
-export const WorkloadDequeueFromVersionResponseBody = WorkerApiDequeueFromVersionResponseBody;
-export type WorkloadDequeueFromVersionResponseBody = z.infer<
-  typeof WorkloadDequeueFromVersionResponseBody
->;
-
 export const WorkloadRunSnapshotsSinceResponseBody = WorkerApiRunSnapshotsSinceResponseBody;
 export type WorkloadRunSnapshotsSinceResponseBody = z.infer<
   typeof WorkloadRunSnapshotsSinceResponseBody