Skip to content

fix(release): fix the release script to find the correct last tag - #3319

Open
pratap0007 wants to merge 1 commit into
tektoncd:mainfrom
pratap0007:fix-release-script
Open

pratap0007 wants to merge 1 commit into
tektoncd:mainfrom
pratap0007:fix-release-script

Conversation

@pratap0007

Copy link
Copy Markdown
Contributor

fix(release): fix the release script to find the correct last tag

  • For minor release lasttag would be latest tag
  • For patch release lasttag would be respective branch latest tag

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 5, 2026
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2026
@divyansh42
divyansh42 requested a balanced review from Copilot October 5, 2026 11:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The fallback can select an unrelated release series or reuse the target tag, producing incorrect changelogs.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Updates the release script to select changelog baselines for minor and patch releases.

Changes:

  • Looks for a same-series tag, with a latest-overall fallback.
  • Determines release type from the patch version rather than branch existence.
  • Uses the selected tag when generating the changelog.
File Description
tekton/​release.sh Updates tag selection, release classification, and release messaging.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tekton/release.sh Outdated
Comment thread tekton/release.sh Outdated
For minor release lasttag would be latest tag
For patch release lasttag would be respective branch latest tag

Signed-off-by: pratap0007 <shverma@redhat.com>
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyansh42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2026
@divyansh42

Copy link
Copy Markdown
Member

/retest

2 similar comments
@pratap0007

Copy link
Copy Markdown
Contributor Author

/retest

@divyansh42

Copy link
Copy Markdown
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants