feat: add profile and contacts fetching from pubky by ben-kaufman · Pull Request #824 · synonymdev/bitkit-android

ben-kaufman · 2026-03-05T15:29:00Z

Integrates Pubky decentralized identity into Bitkit, adding profile authentication, a contacts screen.

What's included

Pubky profile

Authentication flow via Pubky Ring deep links (pubkyauth://) with relay-based session exchange, session persistence in Keychain, and automatic session restoration on launch
Profile page displaying name, bio, links, and a QR code with profile picture overlaid
Home screen integration showing the authenticated user's name and avatar in the header
PubkyService — service layer wrapping paykit (session management) and bitkit-core (auth relay, file fetching, profile/contacts)
PubkyRepo — manages auth state, session lifecycle, profile, and contacts data with all I/O offloaded to background threads
PubkyImage component for loading pubky:// URIs with two-tier (memory + disk) caching
PubkyStore DataStore caches profile name and image URI for instant display before full profile loads
Suggestion card auto-dismiss when user is already authenticated

Pubky contacts

Contacts intro screen with navigation to profile auth if not yet signed in
Contacts list with alphabetical grouping and search
Contact detail screen showing name, bio, links, and copy/share actions
Contacts fetched concurrently on login and session restore; failed fetches fall back to a placeholder

…tkit-android into feat/pubky-profile

app/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt

app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt

app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt

app/src/main/java/to/bitkit/ui/components/PubkyImage.kt

app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

app/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt

app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt

app/src/main/java/to/bitkit/ui/components/PubkyImage.kt

app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt

app/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt

app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

claude

Code review

Found 2 CLAUDE.md compliance issues.

app/src/main/java/to/bitkit/ui/components/PubkyImage.kt

app/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt

app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt

jvsena42 · 2026-03-09T17:27:34Z

Starting review

ovitrif

Submitted couple more pending comments and resolved the ones where code changes applied. The goal is to reach a state where agent can be asked to scan through non-resolved review comments and address those in a new pass.

app/src/main/java/to/bitkit/data/PubkyStore.kt

app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

jvsena42 · 2026-03-12T18:01:29Z

resuming review...

ovitrif

Overall great progress, this is getting closer to being ready.

For some reason my review comments of yesterday night didn't land to your side, likely it was a PEBKAC 🤦🏻 and I forgot to publish review.

There were more nits, but it was lacking the review of contacts review and retest of the new features stack. So this is more comprehensive anyways.

The biggest 2 issues are shown in this video:
https://github.com/user-attachments/assets/b582a575-39fe-4ddf-9e99-868de5a099f2

1. Crash when sharing pk from profile or contact details

1️⃣ 🔴 Basically 2 crash bugs, because shareText is used in viewModels instead of in view layer, the fix is described in comments on the lines which cause the crash. Should be fixed in profile details and contacts details.

2. Inconsistency and missing details on self (my) contact details

2️⃣ 🟠 The other bug (supposedly) is the contact details page for self, seems to be missing the right profile picture. Interesting that in iOS we show the profile page when tapping on the contact list item for self.

3. Inconsistency in sorting irregular profile names

3️⃣ 🔴 Then I noticed a difference between iOS and Android in sorting. iOS seems to do this better: Profiles with non-alphabet starting character are grouped at the top under section header #.
Android shows those at the end of the list, in a separate section for each glyph first char.

contacts.mp4

app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt

app/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt

app/src/main/java/to/bitkit/services/PubkyService.kt

+    suspend fun initialize() =
+        ServiceQueue.CORE.background { paykitInitialize() }


app/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt

app/src/main/java/to/bitkit/ui/screens/contacts/ContactDetailViewModel.kt

app/src/main/java/to/bitkit/ui/screens/contacts/ContactsIntroScreen.kt

app/src/main/java/to/bitkit/ui/screens/contacts/ContactDetailScreen.kt

app/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt

app/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt

piotr-iohk · 2026-03-13T18:11:43Z

Few issues/comments found during testing:

Hardcoded production domains — no staging support

The capabilities in PubkyService are hardcoded to pubky.app / paykit.app:

/pub/paykit.app/v0/:rw,/pub/pubky.app/profile.json:rw,/pub/pubky.app/follows/:rw

For dev/tnet/E2E builds we should be using staging.pubky.app / staging.paykit.app instead — Pubky Ring already distinguishes between staging and production based on homeserver. This will be needed for E2E test automation.

Unrecoverable "Unable to load profile" state

After hitting a profile load failure (possibly related to the staging mismatch above), the app gets stuck on an "Unable to load profile" screen with no way to disconnect/sign out. Resetting wallet and wiping app data from system settings do not clear it - only a full reinstall works. The session seems to persist somewhere that survives both of those operations (Keychain?).
(both probably apply to iOS as well, have not checked yet)

Screen_Recording_20260313_185242_Bitkit.Regtest.mp4

App crash on tapping "share" icon on pubky profile - I think already mentioned by Ovi.
After authorizing in Pubky Ring, the user stays in Ring instead of being redirected back to Bitkit. Would be great if Ring navigated back automatically after approval. Likely a Pubky Ring-side change.

piotr-iohk · 2026-03-16T14:01:49Z

Also My profile in Contacts does not show profile details as opposed to iOS (checked on latest revision 78d16f7), also already mentioned by Ovi:

Screen.Recording.2026-03-16.at.14.03.24.mov

app/src/main/java/to/bitkit/env/Env.kt

ovitrif

retested everything, looking much better but I still see these 2 issues:

own profile	list glyph headers

ovitrif · 2026-03-16T15:14:03Z

app/src/main/java/to/bitkit/env/Env.kt

+            Network.BITCOIN ->
+                "/pub/paykit.app/v0/:rw,/pub/pubky.app/profile.json:rw,/pub/pubky.app/follows/:rw"
+            else ->
+                "/pub/staging.paykit.app/v0/:rw,/pub/staging.pubky.app/profile.json:rw,/pub/pubky.app/follows/:rw"


/pub/pubky.app still in last entry…

should last entry also use …staging… ?!

maybe best to turn this strings-in-when to a string template, where the computing by network only applies to the app's name.

ovitrif · 2026-03-16T15:19:30Z

app/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt

+        contentAlignment = Alignment.Center,
+        modifier = Modifier.fillMaxSize()
+    ) {
+        CircularProgressIndicator(color = Colors.White32)


nit: should start using GradientCircularProgressIndicator in all new implementation from now on, instead of CircularProgressIndicator

ovitrif · 2026-03-16T15:20:30Z

app/src/main/java/to/bitkit/ui/screens/contacts/ContactDetailViewModel.kt

+    }
+
+    fun copyPublicKey() {
+        context.setClipboardText(publicKey, context.getString(R.string.profile__public_key))


aside: this was the other option I didn't share as I am still skeptical on it, but I guess it's ok; the thing to fix was the crash, this alternative fixes it too, at the expense of having to bubble up N callbacks just to lift the copy-to-clipboard action to the viewModel without breaking the principle of not passing viewmodel to inner composables.

ovitrif · 2026-03-16T15:23:00Z

app/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt

+private fun ActionButton(
+    iconRes: Int? = null,
+    imageVector: ImageVector? = null,
+    onClick: () -> Unit,
+    enabled: Boolean = true,
+) {
+    IconButton(
+        onClick = rememberDebouncedClick(onClick = onClick),
+        enabled = enabled,
+        modifier = Modifier
+            .size(48.dp)
+            .clip(CircleShape)
+            .background(
+                Brush.verticalGradient(listOf(Colors.Gray5, Colors.Gray6)),
+                CircleShape,
+            )
+            .border(1.dp, Colors.White10, CircleShape)
+    ) {
+        val tint = if (enabled) Colors.White else Colors.White32
+        when {
+            iconRes != null -> Icon(
+                painter = painterResource(iconRes),
+                contentDescription = null,
+                tint = tint,
+                modifier = Modifier.size(24.dp)
+            )
+            imageVector != null -> Icon(
+                imageVector = imageVector,
+                contentDescription = null,
+                tint = tint,
+                modifier = Modifier.size(24.dp)
+            )
+        }
+    }
+}


nit: it looks to me like these are the same implementations we have in contact detail page.

if this is 100% the same, we should extract to .ui.components, share and reuse.

Suggestion likely impacts:

ActionButton

ProfileLinkRow

jvsena42 · 2026-03-16T16:44:14Z

What is the best way to testing this? A Pubky Ring on staging?

ovitrif · 2026-03-16T17:03:55Z

What is the best way to testing this? A Pubky Ring on staging?

Test in prod, yolo!

piotr-iohk · 2026-03-16T17:35:22Z

What is the best way to testing this? A Pubky Ring on staging?

Test in prod, yolo!

From what I see staging doesn't work still? Or maybe it is because of HTTP-auth required on staging 🤔 (IMO we should solve this and allow testing on staging):

Screen.Recording.2026-03-16.at.18.22.17.mov

piotr-iohk · 2026-03-16T17:50:04Z

What is the best way to testing this? A Pubky Ring on staging?

Test in prod, yolo!

From what I see staging doesn't work still? Or maybe it is because of HTTP-auth required on staging 🤔 (IMO we should solve this and allow testing on staging):

Screen.Recording.2026-03-16.at.18.22.17.mov

Actually started to work after I http-auth'ed to staging.pubky.app in browser... 🤷 👍

feat: add profile fetching from pubky

5983a73

ben-kaufman requested review from jvsena42, ovitrif and piotr-iohk March 5, 2026 15:29

ben-kaufman added 4 commits March 5, 2026 22:29

Merge branch 'master' into feat/pubky-profile

b5f211c

fix build

8d5bac7

Merge branch 'feat/pubky-profile' of https://github.com/synonymdev/bi…

1bdd233

…tkit-android into feat/pubky-profile

fix paykit version

1484f26

claude bot reviewed Mar 5, 2026

View reviewed changes

app/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt Outdated Show resolved Hide resolved

claude bot reviewed Mar 5, 2026

View reviewed changes

app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt Outdated Show resolved Hide resolved

fixes

06a618d