You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The quickstart image contains hardcoded Soroban config settings in local/core/etc/config-settings/p{N}/testnet.json files. These are used when running in --local mode so that the local network has settings consistent with testnet without needing to contact the outside world.
These files frequently drift out of date because they require manual PRs to update. This has been a recurring maintenance burden, with multiple PRs over the past years doing nothing but updating these values:
Issue #715 proposed adding a test that checks whether the settings are up-to-date with testnet. PR #545 attempted to pull settings directly from stellar-core at build time but went stale. Neither was completed.
What would you like to see?
Add a scheduled GitHub Actions workflow (e.g. weekly) that:
Queries the current Soroban config settings from testnet (e.g. via stellar-cli or via RPC and a script using the stellar-xdr to encode to json)
Compares them against the current testnet.json file(s) for the latest protocol version in local/core/etc/config-settings/
If they differ, opens a PR automatically with the updated testnet.json
This would also serve as the detection mechanism requested in #715, since a PR being opened signals drift.
Build-time fetch (as in Pull settings file from stellar-core #545): Pull settings from stellar-core repo at Docker build time. Risk: changes to the source file path/format in stellar-core would break quickstart builds.
Runtime fetch: Have the quickstart container fetch settings from testnet at startup. Breaks the offline/hermetic use case that the hardcoded file exists to support.
What problem does your feature solve?
The quickstart image contains hardcoded Soroban config settings in
local/core/etc/config-settings/p{N}/testnet.jsonfiles. These are used when running in--localmode so that the local network has settings consistent with testnet without needing to contact the outside world.These files frequently drift out of date because they require manual PRs to update. This has been a recurring maintenance burden, with multiple PRs over the past years doing nothing but updating these values:
Issue #715 proposed adding a test that checks whether the settings are up-to-date with testnet. PR #545 attempted to pull settings directly from stellar-core at build time but went stale. Neither was completed.
What would you like to see?
Add a scheduled GitHub Actions workflow (e.g. weekly) that:
stellar-clior via RPC and a script using the stellar-xdr to encode to json)testnet.jsonfile(s) for the latest protocol version inlocal/core/etc/config-settings/testnet.jsonThis would also serve as the detection mechanism requested in #715, since a PR being opened signals drift.
What alternatives are there?
Related