Fix #1314 - Introduce LifecycleEvents to expose events constants to clients#1320
Merged
ricardozanini merged 3 commits intoserverlessworkflow:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a dedicated LifecycleEvents constants class so downstream consumers can reference canonical Serverless Workflow lifecycle CloudEvent type strings, and refactors the lifecycle CloudEvent publisher to use those shared constants.
Changes:
- Added
io.serverlessworkflow.impl.LifecycleEventswith public CloudEvent type constants. - Removed the previously private type constants from
AbstractLifeCyclePublisherand switched to importing fromLifecycleEvents. - Kept
getLifeCycleTypes()behavior intact while centralizing the source of truth for event type strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/ce/AbstractLifeCyclePublisher.java | Replaces in-class private CloudEvent type constants with static imports from the new shared constants class. |
| impl/core/src/main/java/io/serverlessworkflow/impl/LifecycleEvents.java | Adds a public constants holder for official lifecycle CloudEvent type strings for downstream consumption. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fjtirado
approved these changes
Apr 16, 2026
Collaborator
|
@ricardozanini can you format the file in order to merge? |
…nts constants to clients Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
…ents.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
ricardozanini
force-pushed
the
issue-1314
branch
from
e5723f2 to
e78d1d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Fixes #1314
Special notes for reviewers:
Additional information (if needed):