Respect markup comment in non-ruby files#1613
Closed
Earlopain wants to merge 1 commit intoruby:masterfrom
Closed
Conversation
Earlopain
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
Earlopain
commented
Feb 16, 2026
|
|
||
| return unless markup | ||
| if markup | ||
| return RDoc::Parser::Ruby if markup == "tomdoc" |
Contributor
Author
There was a problem hiding this comment.
There doesn't seem to be a tomdoc parser. So I kept this for backwards compatibility.
| selected | ||
| else | ||
| selected = RDoc::Parser.can_parse_by_name(file_path) | ||
| return if selected == RDoc::Parser::Simple |
Contributor
Author
There was a problem hiding this comment.
This one has an empty regexp and would match on any file. This breaks shebang detection, so I explicitly exclude it here.
Contributor
Author
|
It doesn't look like I know what I'm doing. markup is used to control both the parser and markup format and I have no idea what to do about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1597
Prism uses markdown for documentation. In the prism repo itself we can set
rdoc.markup = "markdown"but that doesn't work in ruby/ruby. So I wanted to add the markup directive to the C files that are currently missing them. But it is not respected.